Skip to content

Commit 528cbf7

Browse files
committed
Fix a misleading error message
Format conversions should have been rejected earlier; this conceptually means something else has probably changed. That's not _actually_ reliably true at this point because determineListConversion does not take cannotModifyManifestListReason into account, but that's a different bug, to be fixed some other time. Signed-off-by: Miloslav Trmač <[email protected]>
1 parent af8a892 commit 528cbf7

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

image/copy/multiple.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -318,7 +318,7 @@ func (c *copier) copyMultipleImages(ctx context.Context) (copiedManifest []byte,
318318
// If we can't just use the original value, but we have to change it, flag an error.
319319
if !bytes.Equal(attemptedManifestList, originalManifestList) {
320320
if cannotModifyManifestListReason != "" {
321-
return nil, fmt.Errorf("Manifest list must be converted to type %q to be written to destination, but we cannot modify it: %q", thisListType, cannotModifyManifestListReason)
321+
return nil, fmt.Errorf("Manifest list was edited, but we cannot modify it: %q", cannotModifyManifestListReason)
322322
}
323323
logrus.Debugf("Manifest list has been updated")
324324
} else {

0 commit comments

Comments
 (0)