Skip to content

Commit ca62de1

Browse files
committed
Add some FIXMEs
Signed-off-by: Miloslav Trmač <[email protected]>
1 parent 3dee5f4 commit ca62de1

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

image/copy/multiple.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -216,6 +216,7 @@ func (c *copier) copyMultipleImages(ctx context.Context) (copiedManifest []byte,
216216
case imgspecv1.MediaTypeImageManifest:
217217
forceListMIMEType = imgspecv1.MediaTypeImageIndex
218218
}
219+
// FIXME: This does not take into account cannotModifyManifestListReason.
219220
selectedListType, otherManifestMIMETypeCandidates, err := c.determineListConversion(manifestType, c.dest.SupportedManifestMIMETypes(), forceListMIMEType)
220221
if err != nil {
221222
return nil, fmt.Errorf("determining manifest list type to write to destination: %w", err)

image/internal/manifest/oci_index.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,8 @@ func (index *OCI1IndexPublic) editInstances(editInstances []ListEdit, cannotModi
159159
maps.Copy(index.Manifests[targetIndex].Annotations, editInstance.UpdateAnnotations)
160160
}
161161
}
162+
// FIXME: This does not set updatedAnnotations, so we don’t re-sort images with Zstd instances if some other
163+
// tool created them without the OCI1InstanceAnnotationCompressionZSTD annotation.
162164
addCompressionAnnotations(editInstance.UpdateCompressionAlgorithms, &index.Manifests[targetIndex].Annotations, cannotModifyManifest)
163165
case ListOpAdd:
164166
annotations := map[string]string{}

0 commit comments

Comments
 (0)