test(kubernetes): add unit tests for ProviderSingle functionality (#376)

Signed-off-by: Marc Nuri <[email protected]>

Author: manusa

pkg/kubernetes/provider_kubeconfig_test.go

@@ -18,6 +18,8 @@ type ProviderKubeconfigTestSuite struct {
 }
 
 func (s *ProviderKubeconfigTestSuite) SetupTest() {
+	// Kubeconfig provider is used when the multi-cluster feature is enabled with the kubeconfig strategy.
+	// For this test suite we simulate a kubeconfig with multiple contexts.
 	s.mockServer = test.NewMockServer()
 	kubeconfig := s.mockServer.Kubeconfig()
 	for i := 0; i < 10; i++ {
@@ -84,7 +86,7 @@ func (s *ProviderKubeconfigTestSuite) TestVerifyToken() {
 		s.Len(audiences, 1, "Expected audiences from VerifyToken with empty target")
 		s.Containsf(audiences, "the-audience", "Expected audience the-audience in %v", audiences)
 	})
-	s.Run("VerifyToken returns UserInfo for empty context (default context", func() {
+	s.Run("VerifyToken returns UserInfo for empty context (default context)", func() {
 		userInfo, audiences, err := s.provider.VerifyToken(s.T().Context(), "", "the-token", "the-audience")
 		s.Require().NoError(err, "Expected no error from VerifyToken with empty target")
 		s.Require().NotNil(userInfo, "Expected UserInfo from VerifyToken with empty target")

pkg/kubernetes/provider_single_test.go

@@ -0,0 +1,133 @@
+package kubernetes
+
+import (
+	"net/http"
+	"testing"
+
+	"github.com/containers/kubernetes-mcp-server/internal/test"
+	"github.com/containers/kubernetes-mcp-server/pkg/config"
+	"github.com/stretchr/testify/suite"
+	"k8s.io/client-go/rest"
+)
+
+type ProviderSingleTestSuite struct {
+	BaseProviderSuite
+	mockServer                *test.MockServer
+	originalIsInClusterConfig func() (*rest.Config, error)
+	provider                  Provider
+}
+
+func (s *ProviderSingleTestSuite) SetupTest() {
+	// Single cluster provider is used when in-cluster or when the multi-cluster feature is disabled.
+	// For this test suite we simulate an in-cluster deployment.
+	s.originalIsInClusterConfig = InClusterConfig
+	s.mockServer = test.NewMockServer()
+	InClusterConfig = func() (*rest.Config, error) {
+		return s.mockServer.Config(), nil
+	}
+	provider, err := NewProvider(&config.StaticConfig{})
+	s.Require().NoError(err, "Expected no error creating provider with kubeconfig")
+	s.provider = provider
+}
+
+func (s *ProviderSingleTestSuite) TearDownTest() {
+	InClusterConfig = s.originalIsInClusterConfig
+	if s.mockServer != nil {
+		s.mockServer.Close()
+	}
+}
+
+func (s *ProviderSingleTestSuite) TestType() {
+	s.IsType(&singleClusterProvider{}, s.provider)
+}
+
+func (s *ProviderSingleTestSuite) TestWithNonOpenShiftCluster() {
+	s.Run("IsOpenShift returns false", func() {
+		inOpenShift := s.provider.IsOpenShift(s.T().Context())
+		s.False(inOpenShift, "Expected InOpenShift to return false")
+	})
+}
+
+func (s *ProviderSingleTestSuite) TestWithOpenShiftCluster() {
+	s.mockServer.Handle(&test.InOpenShiftHandler{})
+	s.Run("IsOpenShift returns true", func() {
+		inOpenShift := s.provider.IsOpenShift(s.T().Context())
+		s.True(inOpenShift, "Expected InOpenShift to return true")
+	})
+}
+
+func (s *ProviderSingleTestSuite) TestVerifyToken() {
+	s.mockServer.Handle(http.HandlerFunc(func(w http.ResponseWriter, req *http.Request) {
+		if req.URL.EscapedPath() == "/apis/authentication.k8s.io/v1/tokenreviews" {
+			w.Header().Set("Content-Type", "application/json")
+			_, _ = w.Write([]byte(`
+				{
+					"kind": "TokenReview",
+					"apiVersion": "authentication.k8s.io/v1",
+					"spec": {"token": "the-token"},
+					"status": {
+						"authenticated": true,
+						"user": {
+							"username": "test-user",
+							"groups": ["system:authenticated"]
+						},
+						"audiences": ["the-audience"]
+					}
+				}`))
+		}
+	}))
+	s.Run("VerifyToken returns UserInfo for empty target (default target)", func() {
+		userInfo, audiences, err := s.provider.VerifyToken(s.T().Context(), "", "the-token", "the-audience")
+		s.Require().NoError(err, "Expected no error from VerifyToken with empty target")
+		s.Require().NotNil(userInfo, "Expected UserInfo from VerifyToken with empty target")
+		s.Equalf(userInfo.Username, "test-user", "Expected username test-user, got: %s", userInfo.Username)
+		s.Containsf(userInfo.Groups, "system:authenticated", "Expected group system:authenticated in %v", userInfo.Groups)
+		s.Require().NotNil(audiences, "Expected audiences from VerifyToken with empty target")
+		s.Len(audiences, 1, "Expected audiences from VerifyToken with empty target")
+		s.Containsf(audiences, "the-audience", "Expected audience the-audience in %v", audiences)
+	})
+	s.Run("VerifyToken returns error for non-empty context", func() {
+		userInfo, audiences, err := s.provider.VerifyToken(s.T().Context(), "non-empty", "the-token", "the-audience")
+		s.Require().Error(err, "Expected error from VerifyToken with non-empty target")
+		s.ErrorContains(err, "unable to get manager for other context/cluster with in-cluster strategy", "Expected error about trying to get other cluster")
+		s.Nil(userInfo, "Expected no UserInfo from VerifyToken with non-empty target")
+		s.Nil(audiences, "Expected no audiences from VerifyToken with non-empty target")
+	})
+}
+
+func (s *ProviderSingleTestSuite) TestGetTargets() {
+	s.Run("GetTargets returns single empty target", func() {
+		targets, err := s.provider.GetTargets(s.T().Context())
+		s.Require().NoError(err, "Expected no error from GetTargets")
+		s.Len(targets, 1, "Expected 1 targets from GetTargets")
+		s.Contains(targets, "", "Expected empty target from GetTargets")
+	})
+}
+
+func (s *ProviderSingleTestSuite) TestGetDerivedKubernetes() {
+	s.Run("GetDerivedKubernetes returns Kubernetes for empty target", func() {
+		k8s, err := s.provider.GetDerivedKubernetes(s.T().Context(), "")
+		s.Require().NoError(err, "Expected no error from GetDerivedKubernetes with empty target")
+		s.NotNil(k8s, "Expected Kubernetes from GetDerivedKubernetes with empty target")
+	})
+	s.Run("GetDerivedKubernetes returns error for non-empty target", func() {
+		k8s, err := s.provider.GetDerivedKubernetes(s.T().Context(), "non-empty-target")
+		s.Require().Error(err, "Expected error from GetDerivedKubernetes with non-empty target")
+		s.ErrorContains(err, "unable to get manager for other context/cluster with in-cluster strategy", "Expected error about trying to get other cluster")
+		s.Nil(k8s, "Expected no Kubernetes from GetDerivedKubernetes with non-empty target")
+	})
+}
+
+func (s *ProviderSingleTestSuite) TestGetDefaultTarget() {
+	s.Run("GetDefaultTarget returns empty string", func() {
+		s.Empty(s.provider.GetDefaultTarget(), "Expected fake-context as default target")
+	})
+}
+
+func (s *ProviderSingleTestSuite) TestGetTargetParameterName() {
+	s.Empty(s.provider.GetTargetParameterName(), "Expected empty string as target parameter name")
+}
+
+func TestProviderSingle(t *testing.T) {
+	suite.Run(t, new(ProviderSingleTestSuite))
+}