test:refactor(cmd): test verifies behavior from cobra.Command layer

Previous iteration was running method directly

Author: manusa

pkg/kubernetes-mcp-server/cmd/root_test.go

@@ -23,85 +23,82 @@ func captureOutput(f func() error) (string, error) {
 	return string(out), err
 }
 
-func TestVersion(t *testing.T) {
-	in := &bytes.Buffer{}
+func testStream() (genericiooptions.IOStreams, *bytes.Buffer) {
 	out := &bytes.Buffer{}
-	errOut := io.Discard
-	rootCmd := NewMCPServerOptions(genericiooptions.IOStreams{In: in, Out: out, ErrOut: errOut})
-	rootCmd.Version = true
-	rootCmd.Run()
-	if out.String() != "0.0.0\n" {
-		t.Fatalf("Expected version 0.0.0, got %s", out.String())
+	return genericiooptions.IOStreams{
+		In:     &bytes.Buffer{},
+		Out:    out,
+		ErrOut: io.Discard,
+	}, out
+}
+
+func TestVersion(t *testing.T) {
+	ioStreams, out := testStream()
+	rootCmd := NewMCPServer(ioStreams)
+	rootCmd.SetArgs([]string{"--version"})
+	if err := rootCmd.Execute(); out.String() != "0.0.0\n" {
+		t.Fatalf("Expected version 0.0.0, got %s %v", out.String(), err)
 	}
 }
 
 func TestProfile(t *testing.T) {
+	t.Run("available", func(t *testing.T) {
+		ioStreams, _ := testStream()
+		rootCmd := NewMCPServer(ioStreams)
+		rootCmd.SetArgs([]string{"--help"})
+		o, err := captureOutput(rootCmd.Execute) // --help doesn't use logger/klog, cobra prints directly to stdout
+		if !strings.Contains(o, "MCP profile to use (one of: full) ") {
+			t.Fatalf("Expected all available profiles, got %s %v", o, err)
+		}
+	})
 	t.Run("default", func(t *testing.T) {
-		in := &bytes.Buffer{}
-		out := &bytes.Buffer{}
-		errOut := io.Discard
-		rootCmd := NewMCPServerOptions(genericiooptions.IOStreams{In: in, Out: out, ErrOut: errOut})
-		rootCmd.Version = true
-		rootCmd.LogLevel = 1
-		rootCmd.Complete()
-		rootCmd.Run()
-		if !strings.Contains(out.String(), "- Profile: full") {
-			t.Fatalf("Expected profile 'full', got %s", out)
+		ioStreams, out := testStream()
+		rootCmd := NewMCPServer(ioStreams)
+		rootCmd.SetArgs([]string{"--version", "--log-level=1"})
+		if err := rootCmd.Execute(); !strings.Contains(out.String(), "- Profile: full") {
+			t.Fatalf("Expected profile 'full', got %s %v", out, err)
 		}
 	})
 }
 
 func TestListOutput(t *testing.T) {
 	t.Run("available", func(t *testing.T) {
-		in := &bytes.Buffer{}
-		out := io.Discard
-		errOut := io.Discard
-		rootCmd := NewMCPServer(genericiooptions.IOStreams{In: in, Out: out, ErrOut: errOut})
+		ioStreams, _ := testStream()
+		rootCmd := NewMCPServer(ioStreams)
 		rootCmd.SetArgs([]string{"--help"})
-		o, err := captureOutput(rootCmd.Execute)
+		o, err := captureOutput(rootCmd.Execute) // --help doesn't use logger/klog, cobra prints directly to stdout
 		if !strings.Contains(o, "Output format for resource list operations (one of: yaml, table)") {
-			t.Fatalf("Expected all available outputs, got %s %v", out, err)
+			t.Fatalf("Expected all available outputs, got %s %v", o, err)
 		}
 	})
 	t.Run("defaults to table", func(t *testing.T) {
-		in := &bytes.Buffer{}
-		out := &bytes.Buffer{}
-		errOut := io.Discard
-		rootCmd := NewMCPServerOptions(genericiooptions.IOStreams{In: in, Out: out, ErrOut: errOut})
-		rootCmd.Version = true
-		rootCmd.LogLevel = 1
-		rootCmd.Complete()
-		rootCmd.Run()
-		if !strings.Contains(out.String(), "- ListOutput: table") {
-			t.Fatalf("Expected list-output 'table', got %s", out)
+		ioStreams, out := testStream()
+		rootCmd := NewMCPServer(ioStreams)
+		rootCmd.SetArgs([]string{"--version", "--log-level=1"})
+		if err := rootCmd.Execute(); !strings.Contains(out.String(), "- ListOutput: table") {
+			t.Fatalf("Expected list-output 'table', got %s %v", out, err)
 		}
 	})
 }
 
-func TestDefaultReadOnly(t *testing.T) {
-	in := &bytes.Buffer{}
-	out := &bytes.Buffer{}
-	errOut := io.Discard
-	rootCmd := NewMCPServerOptions(genericiooptions.IOStreams{In: in, Out: out, ErrOut: errOut})
-	rootCmd.Version = true
-	rootCmd.LogLevel = 1
-	rootCmd.Complete()
-	rootCmd.Run()
-	if !strings.Contains(out.String(), " - Read-only mode: false") {
-		t.Fatalf("Expected read-only mode false, got %s", out)
-	}
+func TestReadOnly(t *testing.T) {
+	t.Run("defaults to false", func(t *testing.T) {
+		ioStreams, out := testStream()
+		rootCmd := NewMCPServer(ioStreams)
+		rootCmd.SetArgs([]string{"--version", "--log-level=1"})
+		if err := rootCmd.Execute(); !strings.Contains(out.String(), " - Read-only mode: false") {
+			t.Fatalf("Expected read-only mode false, got %s %v", out, err)
+		}
+	})
 }
 
-func TestDefaultDisableDestructive(t *testing.T) {
-	in := &bytes.Buffer{}
-	out := &bytes.Buffer{}
-	errOut := io.Discard
-	rootCmd := NewMCPServerOptions(genericiooptions.IOStreams{In: in, Out: out, ErrOut: errOut})
-	rootCmd.Version = true
-	rootCmd.LogLevel = 1
-	rootCmd.Complete()
-	rootCmd.Run()
-	if !strings.Contains(out.String(), " - Disable destructive tools: false") {
-		t.Fatalf("Expected disable destructive false, got %s", out)
-	}
+func TestDisableDestructive(t *testing.T) {
+	t.Run("defaults to false", func(t *testing.T) {
+		ioStreams, out := testStream()
+		rootCmd := NewMCPServer(ioStreams)
+		rootCmd.SetArgs([]string{"--version", "--log-level=1"})
+		if err := rootCmd.Execute(); !strings.Contains(out.String(), " - Disable destructive tools: false") {
+			t.Fatalf("Expected disable destructive false, got %s %v", out, err)
+		}
+	})
 }