Remove redundant ssebaseurl parameter from http

ardaguclu · ardaguclu · commit 896d38195f82 · 2025-07-11T17:27:05.000+03:00
diff --git a/pkg/http/http.go b/pkg/http/http.go
@@ -16,7 +16,7 @@ import (
 	"github.com/manusa/kubernetes-mcp-server/pkg/mcp"
 )
 
-func Serve(ctx context.Context, mcpServer *mcp.Server, staticConfig *config.StaticConfig, sseBaseUrl string) error {
+func Serve(ctx context.Context, mcpServer *mcp.Server, staticConfig *config.StaticConfig) error {
 	mux := http.NewServeMux()
 
 	wrappedMux := RequestMiddleware(
@@ -28,7 +28,7 @@ func Serve(ctx context.Context, mcpServer *mcp.Server, staticConfig *config.Stat
 		Handler: wrappedMux,
 	}
 
-	sseServer := mcpServer.ServeSse(sseBaseUrl, httpServer)
+	sseServer := mcpServer.ServeSse(staticConfig.SSEBaseURL, httpServer)
 	streamableHttpServer := mcpServer.ServeHTTP(httpServer)
 	mux.Handle("/sse", sseServer)
 	mux.Handle("/message", sseServer)
diff --git a/pkg/kubernetes-mcp-server/cmd/root.go b/pkg/kubernetes-mcp-server/cmd/root.go
@@ -247,7 +247,7 @@ func (m *MCPServerOptions) Run() error {
 
 	if m.StaticConfig.Port != "" {
 		ctx := context.Background()
-		return internalhttp.Serve(ctx, mcpServer, m.StaticConfig, m.SSEBaseUrl)
+		return internalhttp.Serve(ctx, mcpServer, m.StaticConfig)
 	}
 
 	if err := mcpServer.ServeStdio(); err != nil && !errors.Is(err, context.Canceled) {

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ import (`
`16`	`16`	`"github.com/manusa/kubernetes-mcp-server/pkg/mcp"`
`17`	`17`	`)`
`18`	`18`
`19`		`-func Serve(ctx context.Context, mcpServer mcp.Server, staticConfig config.StaticConfig, sseBaseUrl string) error {`
	`19`	`+func Serve(ctx context.Context, mcpServer mcp.Server, staticConfig config.StaticConfig) error {`
`20`	`20`	`mux := http.NewServeMux()`
`21`	`21`
`22`	`22`	`wrappedMux := RequestMiddleware(`
`@@ -28,7 +28,7 @@ func Serve(ctx context.Context, mcpServer mcp.Server, staticConfig config.Stat`
`28`	`28`	`Handler: wrappedMux,`
`29`	`29`	`}`
`30`	`30`
`31`		`- sseServer := mcpServer.ServeSse(sseBaseUrl, httpServer)`
	`31`	`+ sseServer := mcpServer.ServeSse(staticConfig.SSEBaseURL, httpServer)`
`32`	`32`	`streamableHttpServer := mcpServer.ServeHTTP(httpServer)`
`33`	`33`	`mux.Handle("/sse", sseServer)`
`34`	`34`	`mux.Handle("/message", sseServer)`
Original file line number	Diff line number	Diff line change
`@@ -247,7 +247,7 @@ func (m *MCPServerOptions) Run() error {`
`247`	`247`
`248`	`248`	`if m.StaticConfig.Port != "" {`
`249`	`249`	`ctx := context.Background()`
`250`		`- return internalhttp.Serve(ctx, mcpServer, m.StaticConfig, m.SSEBaseUrl)`
	`250`	`+ return internalhttp.Serve(ctx, mcpServer, m.StaticConfig)`
`251`	`251`	`}`
`252`	`252`
`253`	`253`	`if err := mcpServer.ServeStdio(); err != nil && !errors.Is(err, context.Canceled) {`