test(mcp): speed up tests by not setting the fake kubeconfig master to example.com

Signed-off-by: Marc Nuri <[email protected]>

Author: manusa

pkg/kubernetes/openshift.go

@@ -2,19 +2,15 @@ package kubernetes
 
 import (
 	"context"
-	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+
 	"k8s.io/apimachinery/pkg/runtime/schema"
 )
 
-func (m *Manager) IsOpenShift(ctx context.Context) bool {
+func (m *Manager) IsOpenShift(_ context.Context) bool {
 	// This method should be fast and not block (it's called at startup)
-	timeoutSeconds := int64(5)
-	if _, err := m.dynamicClient.Resource(schema.GroupVersionResource{
-		Group:    "project.openshift.io",
-		Version:  "v1",
-		Resource: "projects",
-	}).List(ctx, metav1.ListOptions{Limit: 1, TimeoutSeconds: &timeoutSeconds}); err == nil {
-		return true
-	}
-	return false
+	_, err := m.discoveryClient.ServerResourcesForGroupVersion(schema.GroupVersion{
+		Group:   "project.openshift.io",
+		Version: "v1",
+	}.String())
+	return err == nil
 }

pkg/mcp/common_test.go

@@ -184,7 +184,7 @@ func testCaseWithContext(t *testing.T, mcpCtx *mcpContext, test func(c *mcpConte
 func (c *mcpContext) withKubeConfig(rc *rest.Config) *api.Config {
 	fakeConfig := api.NewConfig()
 	fakeConfig.Clusters["fake"] = api.NewCluster()
-	fakeConfig.Clusters["fake"].Server = "https://example.com"
+	fakeConfig.Clusters["fake"].Server = "https://127.0.0.1:6443"
 	fakeConfig.Clusters["additional-cluster"] = api.NewCluster()
 	fakeConfig.AuthInfos["fake"] = api.NewAuthInfo()
 	fakeConfig.AuthInfos["additional-auth"] = api.NewAuthInfo()

pkg/mcp/configuration_test.go

@@ -50,7 +50,7 @@ func TestConfigurationView(t *testing.T) {
 			if decoded.Clusters[0].Name != "fake" {
 				t.Errorf("fake-cluster not found: %v", decoded.Clusters)
 			}
-			if decoded.Clusters[0].Cluster.Server != "https://example.com" {
+			if decoded.Clusters[0].Cluster.Server != "https://127.0.0.1:6443" {
 				t.Errorf("fake-server not found: %v", decoded.Clusters)
 			}
 		})