fix: add timeout for IsOpenShift operation

manusa · manusa · commit e8722663b5de · 2025-04-10T14:54:18.000+02:00
diff --git a/pkg/kubernetes/openshift.go b/pkg/kubernetes/openshift.go
@@ -7,11 +7,13 @@ import (
 )
 
 func (k *Kubernetes) IsOpenShift(ctx context.Context) bool {
+	// This method should be fast and not block (it's called at startup)
+	timeoutSeconds := int64(5)
 	if _, err := k.dynamicClient.Resource(schema.GroupVersionResource{
 		Group:    "project.openshift.io",
 		Version:  "v1",
 		Resource: "projects",
-	}).List(ctx, metav1.ListOptions{Limit: 1}); err == nil {
+	}).List(ctx, metav1.ListOptions{Limit: 1, TimeoutSeconds: &timeoutSeconds}); err == nil {
 		return true
 	}
 	return false

Original file line number	Diff line number	Diff line change
`@@ -7,11 +7,13 @@ import (`
`7`	`7`	`)`
`8`	`8`
`9`	`9`	`func (k *Kubernetes) IsOpenShift(ctx context.Context) bool {`
	`10`	`+ // This method should be fast and not block (it's called at startup)`
	`11`	`+ timeoutSeconds := int64(5)`
`10`	`12`	`if _, err := k.dynamicClient.Resource(schema.GroupVersionResource{`
`11`	`13`	`Group: "project.openshift.io",`
`12`	`14`	`Version: "v1",`
`13`	`15`	`Resource: "projects",`
`14`		`- }).List(ctx, metav1.ListOptions{Limit: 1}); err == nil {`
	`16`	`+ }).List(ctx, metav1.ListOptions{Limit: 1, TimeoutSeconds: &timeoutSeconds}); err == nil {`
`15`	`17`	`return true`
`16`	`18`	`}`
`17`	`19`	`return false`