Skip to content

Conversation

@ardaguclu
Copy link
Member

This PR adds support of passing flag values in configurations files as described in #137. Flags are always higher priority than the configuration definitions.

This PR fixes #137

@ardaguclu
Copy link
Member Author

/cc @manusa for review.

@ardaguclu
Copy link
Member Author

/retest

@ardaguclu
Copy link
Member Author

I think, windows-latest failure is not related to this PR?.

@manusa
Copy link
Member

manusa commented Jun 30, 2025

I think, windows-latest failure is not related to this PR?.

doesn't seem related.

PTAL #145 and see if we can put it in first

@ardaguclu
Copy link
Member Author

@manusa could you PTAL?.

@manusa manusa added this to the 0.1.0 milestone Jul 1, 2025 — with automated-tasks
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa merged commit 2a1a3e4 into containers:main Jul 1, 2025
5 checks passed
@ardaguclu ardaguclu deleted the add-flags-config branch July 1, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cmd flags can be provided through config file

2 participants