Skip to content

Conversation

@ardaguclu
Copy link
Member

@ardaguclu ardaguclu commented Jul 1, 2025

Fixes #135
Fixes #117

This is a continuation effort based on this comment #128 (comment).

This PR serves a unified http mux to support sse and streamable http in the same url (with their own specific endpoints). This paves the way for us to provide a singular middlewares such as authorization, audit logs, etc.

Consequently this PR introduces new flag port that will be used for both mcp transport types. This PR deprecates sse-port and http-port in favor of new port flag (we still keep backwards compatibility by only deprecating flags for now).

In the next iterations;

@ardaguclu
Copy link
Member Author

@manusa wondering your opinions about this PR?. Thanks.

@manusa
Copy link
Member

manusa commented Jul 1, 2025

@manusa wondering your opinions about this PR?. Thanks.

❤️ This is exactly what I had in mind

I haven't checked it thoroughly, but I think that the mux impl belongs elsewhere (probably in the mcp package.

@ardaguclu
Copy link
Member Author

I haven't checked it thoroughly, but I think that the mux impl belongs elsewhere (probably in the mcp package.

We'll have to catch sig terms and exit the entire application

@ardaguclu
Copy link
Member Author

This PR fixes #135

@manusa manusa added this to the 0.1.0 milestone Jul 1, 2025 — with automated-tasks
@ardaguclu
Copy link
Member Author

This PR fixes #117 as well

Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa merged commit e6b1903 into containers:main Jul 2, 2025
5 checks passed
@ardaguclu ardaguclu deleted the use-custom-mux-2 branch July 2, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Intercept http calls of remote MCP Transportation to manage OAuth Streamable HTTP container image

2 participants