feat: add helm history tool #423
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamsudip
force-pushed
the
main
branch
2 times, most recently
from
684b67a to
64fd609
Compare
Signed-off-by: iamsudip <[email protected]> Signed-off-by: iamsudip <[email protected]>
Signed-off-by: iamsudip <[email protected]>
iamsudip
commented
Oct 30, 2025
| if len(releases) == 0 { | ||
| return fmt.Sprintf("No history found for release %s", name), nil | ||
| } | ||
| if max > 0 && len(releases) > max { |
There was a problem hiding this comment.
I had to do it manually here cause helm cli also does same, the history object has a field Max, but that is still not used in history.Run() method to limit the result. So we fetch all, limit on client side to mimic the same behaviour of cli.
|
@manusa @ardaguclu Please review! |
Don't worry, we'll look into it. One of the things we want to consider is if we want to keep having helm as part of the default toolsets or make it opt-in instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.