Use PowerShell command to interact with Hyper-V

Replace wmi calls with powershell commands. This should improve error messages and remove need of executing this code with escalating privileges. The workflow should be the same, the most changes is in 'MemorySettings' memory field names and types, it should be set in bytes. And 'ProcessorSettings' has other name for processors count field.

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

Author: evidolob

cmd/createvm/main.go

@@ -9,6 +9,7 @@ import (
 	"path/filepath"
 
 	"github.com/containers/libhvee/pkg/hypervctl"
+	"github.com/containers/libhvee/pkg/powershell"
 )
 
 func main() {
@@ -20,6 +21,14 @@ func main() {
 		return
 	}
 
+	if err := powershell.HypervAvailable(); err != nil {
+		panic(err)
+	}
+
+	if !powershell.IsHypervAdministrator() {
+		panic(powershell.ErrNotAdministrator)
+	}
+
 	vmName := os.Args[1]
 	vhdxFile := abs(os.Args[2])
 	isoFile := abs(os.Args[3])
@@ -37,21 +46,28 @@ func main() {
 		}
 	}
 
+	if exists, err := vmm.Exists(vmName); err != nil {
+		panic(err)
+	} else if exists {
+		panic(fmt.Errorf("machine %s already exists", vmName))
+	}
+
 	// System
 	systemSettings, err := hypervctl.NewSystemSettingsBuilder().
 		PrepareSystemSettings(vmName, nil).
 		PrepareMemorySettings(func(ms *hypervctl.MemorySettings) {
 			ms.DynamicMemoryEnabled = true
-			ms.VirtualQuantity = 8192 // Startup memory
-			ms.Reservation = 1024     // min
-			ms.Limit = 16384          // max
+			ms.StartupBytes = 8192 * 1024 * 1024 // 8GB
+			ms.MinimumBytes = 1024 * 1024 * 1024 // 1GB
+			ms.MaximumBytes = 16384 * 1024 * 1024 // 16GB
 		}).
 		PrepareProcessorSettings(func(ps *hypervctl.ProcessorSettings) {
-			ps.VirtualQuantity = 4 // 4 cores
+			ps.Count = 4 // 4 cores
 		}).
 		Build()
 
 	if err != nil {
+		fmt.Fprintf(os.Stderr, "error building system settings: %s\n", err)
 		panic(err)
 	}
 
@@ -60,7 +76,7 @@ func main() {
 	err = hypervctl.NewDriveSettingsBuilder(systemSettings).
 		AddScsiController().
 		AddSyntheticDiskDrive(0).
-		DefineVirtualHardDisk(vhdxFile, func(vhdss *hypervctl.VirtualHardDiskStorageSettings) {
+		DefineVirtualHardDisk(vhdxFile, func(vhdss *hypervctl.HardDiskDriveSettings) {
 			// set extra params like
 			// vhdss.IOPSLimit = 5000
 		}).
@@ -94,11 +110,8 @@ func main() {
 		panic(err)
 	}
 
-	if err = vm.AddKeyValuePair("fun", "pair"); err != nil {
-		panic(err)
-	}
 
-	fmt.Println(vm.Path())
+	fmt.Println(vm.Name)
 
 	fmt.Println("Done!")
 }

cmd/dumpvms/main.go

@@ -9,6 +9,7 @@ import (
 	"os"
 
 	"github.com/containers/libhvee/pkg/hypervctl"
+	"github.com/containers/libhvee/pkg/powershell"
 )
 
 const (
@@ -31,7 +32,7 @@ func getVms() (string, error) {
 
 func dumpSummary() (string, error) {
 	vmms := hypervctl.VirtualMachineManager{}
-	summs, err := vmms.GetSummaryInformation(hypervctl.SummaryRequestNearAll)
+	summs, err := vmms.GetSummaryInformation()
 	if err != nil {
 		return "", fmt.Errorf("Could not retrieve virtual machine summaries: %v\n", err) // nolint:staticcheck
 	}
@@ -51,6 +52,14 @@ func main() {
 		err    error
 		result string
 	)
+	if err := powershell.HypervAvailable(); err != nil {
+		panic(err)
+	}
+
+	if !powershell.IsHypervAdministrator() {
+		panic(powershell.ErrNotAdministrator)
+	}
+	
 	args := os.Args
 	if len(args) != 2 {
 		printHelp()

cmd/kvpctl/main.go

@@ -12,6 +12,7 @@ import (
 
 	"github.com/containers/libhvee/pkg/hypervctl"
 	"github.com/containers/libhvee/pkg/kvp/ginsu"
+	"github.com/containers/libhvee/pkg/powershell"
 	"github.com/sirupsen/logrus"
 	"golang.org/x/sys/windows"
 )
@@ -68,6 +69,14 @@ func main() {
 		printHelp()
 	}
 
+	if err := powershell.HypervAvailable(); err != nil {
+		panic(err)
+	}
+
+	if !powershell.IsHypervAdministrator() {
+		panic(powershell.ErrNotAdministrator)
+	}
+
 	subCmd := getSubCommand(os.Args[2])
 	if subCmd == unknown {
 		fmt.Printf("error: unknown command %s\n", os.Args[2])

cmd/managevm/main.go

@@ -0,0 +1,70 @@
+package main
+
+import (
+	"fmt"
+	"os"
+
+	"github.com/containers/libhvee/pkg/hypervctl"
+	"github.com/containers/libhvee/pkg/powershell"
+)
+
+func main() {
+
+	if err := powershell.HypervAvailable(); err != nil {
+		panic(err)
+	}
+
+	if !powershell.IsHypervAdministrator() {
+		panic(powershell.ErrNotAdministrator)
+	}
+
+	if len(os.Args) < 2 {
+		fmt.Printf("Usage: %s <vm name> <start|stop|restart|status|remove> \n\n", os.Args[0])
+		return
+	}
+
+	vmName := os.Args[1]
+	action := os.Args[2]
+
+	vmm := hypervctl.VirtualMachineManager{}
+
+	exists, _, err := vmm.GetMachineExists(vmName)
+	if err != nil {
+		panic(err)
+	}
+	if !exists {
+		panic(fmt.Errorf("VM %s does not exist", vmName))
+	}
+
+	vm, err := vmm.GetMachine(vmName)
+	if err != nil {
+		panic(err)
+	}
+
+	switch action {
+	case "remove":
+		err = vm.Remove(vm.HardDrives[0].Path)
+		if err != nil {
+			fmt.Println(err)
+			panic(err)
+		}
+	case "start":
+		err = vm.Start()
+	case "stop":
+		err = vm.Stop()
+	case "restart":
+		err = vm.Stop()
+		if err != nil {
+			panic(err)
+		}
+		err = vm.Start()
+		if err != nil {
+			panic(err)
+		}
+	case "status":
+		fmt.Println(vm.GetState())
+	}
+	if err != nil {
+		panic(err)
+	}
+}

cmd/updatevm/main.go

@@ -9,12 +9,21 @@ import (
 	"strconv"
 
 	"github.com/containers/libhvee/pkg/hypervctl"
+	"github.com/containers/libhvee/pkg/powershell"
 )
 
 func main() {
 
+	if err := powershell.HypervAvailable(); err != nil {
+		panic(err)
+	}
+
+	if !powershell.IsHypervAdministrator() {
+		panic(powershell.ErrNotAdministrator)
+	}
+
 	if len(os.Args) < 4 {
-		fmt.Printf("Usage: %s <vm name> <cores> <static mem>\n\n", os.Args[0])
+		fmt.Printf("Usage: %s <vm name> <cores> <static mem in MB>\n\n", os.Args[0])
 
 		return
 	}
@@ -37,12 +46,12 @@ func main() {
 	}
 
 	err = vm.UpdateProcessorMemSettings(func(ps *hypervctl.ProcessorSettings) {
-		ps.VirtualQuantity = cores
+		ps.Count = int64(cores)
 	}, func(ms *hypervctl.MemorySettings) {
 		ms.DynamicMemoryEnabled = false
-		ms.VirtualQuantity = mem
-		ms.Limit = mem
-		ms.Reservation = mem
+		ms.StartupBytes = mem * 1024 * 1024
+		ms.MaximumBytes = mem * 1024 * 1024
+		ms.MinimumBytes = mem * 1024 * 1024
 	})
 	if err != nil {
 		panic(err)