tests: Make runner output pretty, tabulated, visible when test hangs

Signed-off-by: Matej Hrica <[email protected]>

Author: mtjhrc

tests/runner/src/main.rs

@@ -133,16 +133,12 @@ fn setup_namespace_and_run(test_setup: TestSetup) -> anyhow::Result<()> {
     }
 }
 
-fn run_single_test(test_case: &str, base_dir: &PathBuf, keep_all: bool) -> anyhow::Result<bool> {
+fn run_single_test(test_case: &str, base_dir: &PathBuf, keep_all: bool, max_name_len: usize) -> anyhow::Result<bool> {
     let executable = env::current_exe().context("Failed to detect current executable")?;
     let test_dir = base_dir.join(test_case);
     fs::create_dir(&test_dir).context("Failed to create test directory")?;
 
-    eprintln!(
-        "[{}] running in dir {} ...",
-        test_case,
-        test_dir.display()
-    );
+    eprint!("[{test_case}] {:.<width$} ", "", width = max_name_len - test_case.len() + 3);
 
     // Create log file for stderr
     let log_path = test_dir.join("log.txt");
@@ -168,14 +164,14 @@ fn run_single_test(test_case: &str, base_dir: &PathBuf, keep_all: bool) -> anyho
 
     match result {
         Ok(()) => {
-            println!("[{test_case}]: OK");
+            eprintln!(" OK");
             if !keep_all {
                 let _ = fs::remove_dir_all(&test_dir);
             }
             Ok(true)
         }
         Err(_e) => {
-            println!("[{test_case}]: FAIL (dir {:?} kept)", test_dir);
+            eprintln!(" FAIL");
             Ok(false)
         }
     }
@@ -195,37 +191,41 @@ fn run_tests(test_case: &str, base_dir: Option<PathBuf>, keep_all: bool) -> anyh
         }
     };
 
-    eprintln!("Test base directory: {}", base_dir.display());
-
     let mut num_tests = 1;
     let mut num_ok: usize = 0;
 
     if test_case == "all" {
-        let test_cases = test_cases();
-        num_tests = test_cases.len();
+        let all_tests = test_cases();
+        num_tests = all_tests.len();
+        let max_name_len = all_tests.iter().map(|t| t.name.len()).max().unwrap_or(0);
 
         for TestCase {
             name,
             test: _,
             requires_namespace: _,
-        } in test_cases
+        } in all_tests
         {
-            num_ok += run_single_test(name, &base_dir, keep_all).context(name)? as usize;
+            num_ok += run_single_test(name, &base_dir, keep_all, max_name_len).context(name)? as usize;
         }
     } else {
-        num_ok += run_single_test(test_case, &base_dir, keep_all).context(test_case.to_string())? as usize;
+        let max_name_len = test_case.len();
+        num_ok += run_single_test(test_case, &base_dir, keep_all, max_name_len).context(test_case.to_string())? as usize;
     }
 
     let num_failures = num_tests - num_ok;
     if num_failures > 0 {
-        println!("\nFAIL (PASSED {num_ok}/{num_tests})");
+        eprintln!("\nFAIL ({num_ok}/{num_tests} passed)");
+        eprintln!("Test artifacts: {}", base_dir.display());
         anyhow::bail!("")
     } else {
         // Clean up base dir if all tests passed and it's empty
         if !keep_all {
             let _ = fs::remove_dir(&base_dir);
         }
-        println!("\nOK (PASSED {num_ok}/{num_tests})");
+        eprintln!("\nOK ({num_ok}/{num_tests} passed)");
+        if keep_all {
+            eprintln!("Test artifacts: {}", base_dir.display());
+        }
     }
 
     Ok(())