virtio/snd: apply clippy suggestions

Signed-off-by: Sergio Lopez <[email protected]>

Author: slp

src/devices/src/virtio/snd/audio_backends/pipewire.rs

@@ -194,7 +194,7 @@ impl AudioBackend for PwBackend {
             .write()
             .unwrap()
             .get_mut(stream_id as usize)
-            .ok_or_else(|| Error::StreamWithIdNotFound(stream_id))?
+            .ok_or(Error::StreamWithIdNotFound(stream_id))?
             .state
             .prepare();
         if let Err(err) = prepare_result {
@@ -501,7 +501,7 @@ impl AudioBackend for PwBackend {
             .write()
             .unwrap()
             .get_mut(stream_id as usize)
-            .ok_or_else(|| Error::StreamWithIdNotFound(stream_id))?
+            .ok_or(Error::StreamWithIdNotFound(stream_id))?
             .state
             .release();
         if let Err(err) = release_result {
@@ -530,7 +530,7 @@ impl AudioBackend for PwBackend {
             .write()
             .unwrap()
             .get_mut(stream_id as usize)
-            .ok_or_else(|| Error::StreamWithIdNotFound(stream_id))?
+            .ok_or(Error::StreamWithIdNotFound(stream_id))?
             .state
             .start();
         if let Err(err) = start_result {
@@ -555,7 +555,7 @@ impl AudioBackend for PwBackend {
             .write()
             .unwrap()
             .get_mut(stream_id as usize)
-            .ok_or_else(|| Error::StreamWithIdNotFound(stream_id))?
+            .ok_or(Error::StreamWithIdNotFound(stream_id))?
             .state
             .stop();
         if let Err(err) = stop_result {

src/devices/src/virtio/snd/stream.rs

@@ -38,7 +38,7 @@ type Result<T> = std::result::Result<T, Error>;
 /// - `SET PARAMETERS`
 ///
 ///   The driver negotiates the stream parameters (format, transport, etc) with
-/// the device.
+///   the device.
 ///
 ///   Possible valid transitions: `SET PARAMETERS`, `PREPARE`.
 ///
@@ -47,7 +47,7 @@ type Result<T> = std::result::Result<T, Error>;
 ///   The device prepares the stream (allocates resources, etc).
 ///
 ///   Possible valid transitions: `SET PARAMETERS`, `PREPARE`, `START`,
-/// `RELEASE`.   Output only: the driver transfers data for pre-buffing.
+///   `RELEASE`.   Output only: the driver transfers data for pre-buffing.
 ///
 /// - `START`
 ///

src/devices/src/virtio/snd/worker.rs

@@ -661,7 +661,7 @@ impl SndWorker {
         }
 
         if !stream_ids.is_empty() {
-            let b = self.audio_backend.write().unwrap();
+            let b = self.audio_backend.read().unwrap();
             for id in stream_ids {
                 b.write(id).unwrap();
             }