Skip to content

Commit 89d72dd

Browse files
committed
test fails with arch_memory_regions missing argument #3
arch_memory_regions needs 3 arguments, while it previously used to need 2. This was updated in arch/src/x86, but not in aarch64 and riscv64 Added a 3rd parameter 'None' where it was missing. Fixes: #435 Signed-off-by: Pepper Gray <[email protected]>
1 parent 246b3f7 commit 89d72dd

File tree

4 files changed

+12
-12
lines changed

4 files changed

+12
-12
lines changed

src/arch/src/aarch64/linux/regs.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ mod tests {
153153
let kvm = Kvm::new().unwrap();
154154
let vm = kvm.create_vm().unwrap();
155155
let vcpu = vm.create_vcpu(0).unwrap();
156-
let (_mem_info, regions) = arch_memory_regions(layout::FDT_MAX_SIZE + 0x1000, 0);
156+
let (_mem_info, regions) = arch_memory_regions(layout::FDT_MAX_SIZE + 0x1000, 0, None);
157157
let mem = GuestMemoryMmap::from_ranges(&regions).expect("Cannot initialize memory");
158158

159159
match setup_regs(&vcpu, 0, 0x0, &mem).unwrap_err() {

src/arch/src/aarch64/mod.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -123,31 +123,31 @@ mod tests {
123123

124124
#[test]
125125
fn test_regions_lt_1024gb() {
126-
let (_mem_info, regions) = arch_memory_regions(1usize << 29, 0);
126+
let (_mem_info, regions) = arch_memory_regions(1usize << 29, 0, None);
127127
assert_eq!(1, regions.len());
128128
assert_eq!(GuestAddress(super::layout::DRAM_MEM_START), regions[0].0);
129129
assert_eq!(1usize << 29, regions[0].1);
130130
}
131131

132132
#[test]
133133
fn test_regions_gt_1024gb() {
134-
let (_mem_info, regions) = arch_memory_regions(1usize << 41, 0);
134+
let (_mem_info, regions) = arch_memory_regions(1usize << 41, 0, None);
135135
assert_eq!(1, regions.len());
136136
assert_eq!(GuestAddress(super::layout::DRAM_MEM_START), regions[0].0);
137137
assert_eq!(super::layout::DRAM_MEM_MAX_SIZE, regions[0].1 as u64);
138138
}
139139

140140
#[test]
141141
fn test_get_fdt_addr() {
142-
let (_mem_info, regions) = arch_memory_regions(layout::FDT_MAX_SIZE - 0x1000, 0);
142+
let (_mem_info, regions) = arch_memory_regions(layout::FDT_MAX_SIZE - 0x1000, 0, None);
143143
let mem = GuestMemoryMmap::from_ranges(&regions).expect("Cannot initialize memory");
144144
assert_eq!(get_fdt_addr(&mem), layout::DRAM_MEM_START);
145145

146-
let (_mem_info, regions) = arch_memory_regions(layout::FDT_MAX_SIZE, 0);
146+
let (_mem_info, regions) = arch_memory_regions(layout::FDT_MAX_SIZE, 0, None);
147147
let mem = GuestMemoryMmap::from_ranges(&regions).expect("Cannot initialize memory");
148148
assert_eq!(get_fdt_addr(&mem), layout::DRAM_MEM_START);
149149

150-
let (_mem_info, regions) = arch_memory_regions(layout::FDT_MAX_SIZE + 0x1000, 0);
150+
let (_mem_info, regions) = arch_memory_regions(layout::FDT_MAX_SIZE + 0x1000, 0, None);
151151
let mem = GuestMemoryMmap::from_ranges(&regions).expect("Cannot initialize memory");
152152
assert_eq!(get_fdt_addr(&mem), 0x1000 + layout::DRAM_MEM_START);
153153
}

src/arch/src/riscv64/linux/regs.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ mod tests {
9090
let kvm = Kvm::new().unwrap();
9191
let vm = kvm.create_vm().unwrap();
9292
let vcpu = vm.create_vcpu(0).unwrap();
93-
let (_mem_info, regions) = arch_memory_regions(layout::FDT_MAX_SIZE + 0x1000, 0);
93+
let (_mem_info, regions) = arch_memory_regions(layout::FDT_MAX_SIZE + 0x1000, 0, None);
9494
let mem = GuestMemoryMmap::from_ranges(&regions).expect("Cannot initialize memory");
9595

9696
match setup_regs(&vcpu, 0, 0x0, &mem).unwrap_err() {

src/arch/src/riscv64/mod.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -112,31 +112,31 @@ mod tests {
112112

113113
#[test]
114114
fn test_regions_lt_1024gb() {
115-
let (_mem_info, regions) = arch_memory_regions(1usize << 29, 0);
115+
let (_mem_info, regions) = arch_memory_regions(1usize << 29, 0, None);
116116
assert_eq!(1, regions.len());
117117
assert_eq!(GuestAddress(super::layout::DRAM_MEM_START), regions[0].0);
118118
assert_eq!(1usize << 29, regions[0].1);
119119
}
120120

121121
#[test]
122122
fn test_regions_gt_1024gb() {
123-
let (_mem_info, regions) = arch_memory_regions(1usize << 41, 0);
123+
let (_mem_info, regions) = arch_memory_regions(1usize << 41, 0, None);
124124
assert_eq!(1, regions.len());
125125
assert_eq!(GuestAddress(super::layout::DRAM_MEM_START), regions[0].0);
126126
assert_eq!(super::layout::DRAM_MEM_MAX_SIZE, regions[0].1 as u64);
127127
}
128128

129129
#[test]
130130
fn test_get_fdt_addr() {
131-
let (_mem_info, regions) = arch_memory_regions(layout::FDT_MAX_SIZE - 0x1000, 0);
131+
let (_mem_info, regions) = arch_memory_regions(layout::FDT_MAX_SIZE - 0x1000, 0, None);
132132
let mem = GuestMemoryMmap::from_ranges(&regions).expect("Cannot initialize memory");
133133
assert_eq!(get_fdt_addr(&mem), layout::DRAM_MEM_START);
134134

135-
let (_mem_info, regions) = arch_memory_regions(layout::FDT_MAX_SIZE, 0);
135+
let (_mem_info, regions) = arch_memory_regions(layout::FDT_MAX_SIZE, 0, None);
136136
let mem = GuestMemoryMmap::from_ranges(&regions).expect("Cannot initialize memory");
137137
assert_eq!(get_fdt_addr(&mem), layout::DRAM_MEM_START);
138138

139-
let (_mem_info, regions) = arch_memory_regions(layout::FDT_MAX_SIZE + 0x1000, 0);
139+
let (_mem_info, regions) = arch_memory_regions(layout::FDT_MAX_SIZE + 0x1000, 0, None);
140140
let mem = GuestMemoryMmap::from_ranges(&regions).expect("Cannot initialize memory");
141141
assert_eq!(get_fdt_addr(&mem), 0x1000 + layout::DRAM_MEM_START);
142142
}

0 commit comments

Comments
 (0)