Add virtio-input device and implement input support in the reference implementation #415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtjhrc
force-pushed
the
input-and-touch
branch
10 times, most recently
from
febeffb to
9b74ac8
Compare
We were using VecDeque::pop instead of ::pop_front like inteded, oops. Signed-off-by: Matej Hrica <[email protected]>
Previously we only provided RawFd. Signed-off-by: Matej Hrica <[email protected]>
The device can be configured using 2 vtables one providing the callbacks for querying configuration parameters of the device and other vtable for delivering the actual input events. Signed-off-by: Matej Hrica <[email protected]>
Introduce krun_add_input_device_fd, allowing the user to pass a file descriptor to a /dev/input/event* device, which will be become available in the guest. Signed-off-by: Matej Hrica <[email protected]>
The send_many method is more convinient, should be more efficient and can also be more robust - all of the messages are sent atomically. Signed-off-by: Matej Hrica <[email protected]>
Signed-off-by: Matej Hrica <[email protected]>
mtjhrc
force-pushed
the
input-and-touch
branch
4 times, most recently
from
6be8b3e to
a35dad4
Compare
Signed-off-by: Matej Hrica <[email protected]>
Signed-off-by: Matej Hrica <[email protected]>
mtjhrc
force-pushed
the
input-and-touch
branch
from
a35dad4 to
61339f0
Compare
mtjhrc
requested review from
MatiasVara,
jakecorrenti,
slp and
tylerfanelli
as code owners
slp
requested changes
Oct 10, 2025
| device_state: DeviceState::Inactive, | ||
| cfg: InputConfig::new(), | ||
| worker_thread: None, | ||
| worker_stopfd: EventFd::new(libc::EFD_NONBLOCK).map_err(InputError::EventFd)?, |
There was a problem hiding this comment.
Please use utils::eventfd::EFD_NONBLOCK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a generic
virtio-inputdevice, that can be used either by specifying a callbacks for configuring the device and generating input events, or by forwarding a/dev/input/event*.This also hooks up the functionality for
gui_vmexample (keyboard and touchscreen).