Skip to content

Commit 1fc09ba

Browse files
committed
netlink_route: remove NLM_F_ACK from dump requests
It seems to be a NOP with NLM_F_DUMP and setting it doesn't seem to do anything. Checking with iproute they don't set it on dumps so let's not do it here either. Signed-off-by: Paul Holzinger <pholzing@redhat.com> (cherry picked from commit c552dc4) Signed-off-by: Paul Holzinger <pholzing@redhat.com>
1 parent bd47eaf commit 1fc09ba

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

src/network/netlink_route.rs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -326,8 +326,7 @@ impl Socket<NetlinkRoute> {
326326
table.unwrap_or(libc::RT_TABLE_MAIN.into()),
327327
));
328328

329-
let results =
330-
self.make_netlink_request(RouteNetlinkMessage::GetRoute(msg), NLM_F_DUMP | NLM_F_ACK)?;
329+
let results = self.make_netlink_request(RouteNetlinkMessage::GetRoute(msg), NLM_F_DUMP)?;
331330

332331
let mut routes = Vec::with_capacity(results.len());
333332

@@ -352,8 +351,7 @@ impl Socket<NetlinkRoute> {
352351
let mut msg = LinkMessage::default();
353352
msg.attributes.append(nlas);
354353

355-
let results =
356-
self.make_netlink_request(RouteNetlinkMessage::GetLink(msg), NLM_F_DUMP | NLM_F_ACK)?;
354+
let results = self.make_netlink_request(RouteNetlinkMessage::GetLink(msg), NLM_F_DUMP)?;
357355

358356
let mut links = Vec::with_capacity(results.len());
359357

0 commit comments

Comments
 (0)