Move up vm cache dir creation logic

Currently, the vm cache logic is all over the place making
it difficult to implement locks. Although this requires a
refactoring, let's move the creation of the cache directory
one level up, to allow for more locks granularity.

Signed-off-by: German Maglione <[email protected]>

Author: germag

pkg/bootc/bootc_disk.go

@@ -103,6 +103,12 @@ func (p *BootcDisk) Install(quiet bool) (err error) {
 		return
 	}
 
+	// Create VM cache dir; one per oci bootc image
+	p.Directory = filepath.Join(p.User.CacheDir(), p.ImageId)
+	if err := os.MkdirAll(p.Directory, os.ModePerm); err != nil {
+		return fmt.Errorf("error while making bootc disk directory: %w", err)
+	}
+
 	err = p.getOrInstallImageToDisk(quiet)
 	if err != nil {
 		return
@@ -246,12 +252,6 @@ func (p *BootcDisk) pullImage() (err error) {
 	p.ImageId = imageId
 	p.RepoTag = image.RepoTags[0]
 
-	// Create VM cache dir; one per oci bootc image
-	p.Directory = filepath.Join(p.User.CacheDir(), imageId)
-	if err := os.MkdirAll(p.Directory, os.ModePerm); err != nil {
-		return fmt.Errorf("error while making bootc disk directory: %w", err)
-	}
-
 	return
 }