Fix playground tests, system out of storage errors (#3428)

* chore(tests): fixing model deletion logic

Signed-off-by: Tibor Dancs <[email protected]>

* chore(tests): removing playground-incompatible models

Signed-off-by: Tibor Dancs <[email protected]>

---------

Signed-off-by: Tibor Dancs <[email protected]>

Author: ScrewTSW

tests/playwright/src/ai-lab-extension.spec.ts

@@ -421,20 +421,17 @@ test.describe.serial(`AI Lab extension installation and verification`, () => {
           .toBe('RUNNING');
       });
 
-      test(`Delete model service for ${modelName}`, async () => {
+      test(`Delete model service and model for ${modelName}`, async () => {
         test.setTimeout(150_000);
-        const modelServicePage = await modelServiceDetailsPage.deleteService();
-        await playExpect(modelServicePage.heading).toBeVisible({ timeout: 120_000 });
+        await cleanupServices();
+        await deleteAllModels();
       });
     });
   });
 
-  [
-    'ibm-granite/granite-3.3-8b-instruct-GGUF',
-    'instructlab/granite-7b-lab-GGUF',
-    'instructlab/merlinite-7b-lab-GGUF',
-    'TheBloke/Mistral-7B-Instruct-v0.2-GGUF',
-  ].forEach(modelName => {
+  // Do not use non-instruct models in playground tests.
+  // They break out of guilderails and fail the tests.
+  ['ibm-granite/granite-3.3-8b-instruct-GGUF', 'TheBloke/Mistral-7B-Instruct-v0.2-GGUF'].forEach(modelName => {
     test.describe.serial(`AI Lab playground creation and deletion for ${modelName}`, { tag: '@smoke' }, () => {
       let catalogPage: AILabCatalogPage;
       let playgroundsPage: AILabPlaygroundsPage;
@@ -515,7 +512,8 @@ test.describe.serial(`AI Lab extension installation and verification`, () => {
 
       test.afterAll(`Cleaning up service model`, async () => {
         test.setTimeout(60_000);
-        await cleanupServiceModels();
+        await cleanupServices();
+        await deleteAllModels();
       });
     });
   });
@@ -640,14 +638,15 @@ test.describe.serial(`AI Lab extension installation and verification`, () => {
 
         await restartApp(appName);
         await stopAndDeleteApp(appName);
-        await cleanupServiceModels();
+        await cleanupServices();
       });
 
       test.afterAll(`Ensure cleanup of "${appName}" app, related service, and images`, async ({ navigationBar }) => {
         test.setTimeout(150_000);
 
         await stopAndDeleteApp(appName);
-        await cleanupServiceModels();
+        await cleanupServices();
+        await deleteAllModels();
         await deleteUnusedImages(navigationBar);
       });
     });
@@ -716,7 +715,7 @@ test.describe.serial(`AI Lab extension installation and verification`, () => {
   });
 });
 
-async function cleanupServiceModels(): Promise<void> {
+async function cleanupServices(): Promise<void> {
   try {
     const modelServicePage = await aiLabPage.navigationBar.openServices();
     await modelServicePage.waitForLoad();
@@ -727,6 +726,12 @@ async function cleanupServiceModels(): Promise<void> {
   }
 }
 
+async function deleteAllModels(): Promise<void> {
+  const modelCatalogPage = await aiLabPage.navigationBar.openCatalog();
+  await modelCatalogPage.waitForLoad();
+  await modelCatalogPage.deleteAllModels();
+}
+
 async function restartApp(appName: string): Promise<void> {
   const aiRunningAppsPage = await aiLabPage.navigationBar.openRunningApps();
   const aiApp = await aiRunningAppsPage.getRowForApp(appName);

tests/playwright/src/model/ai-lab-catalog-page.ts

@@ -50,6 +50,12 @@ export class AILabCatalogPage extends AILabBasePage {
     return undefined;
   }
 
+  async getModelNameByRow(row: Locator): Promise<string> {
+    const modelNameCell = row.getByLabel('Model Name');
+    const modelName = await modelNameCell.textContent();
+    return modelName?.trim() ?? '';
+  }
+
   async downloadModel(modelName: string): Promise<void> {
     const modelRow = await this.getModelRowByName(modelName);
     if (!modelRow) {
@@ -75,16 +81,35 @@ export class AILabCatalogPage extends AILabBasePage {
   }
 
   async deleteModel(modelName: string): Promise<void> {
+    if (!modelName || modelName.trim() === '') {
+      console.warn('Model name is empty, skipping deletion.');
+      return;
+    }
     const modelRow = await this.getModelRowByName(modelName);
     if (!modelRow) {
       throw new Error(`Model ${modelName} not found`);
     }
     const deleteButton = modelRow.getByRole('button', { name: 'Delete Model' });
-    await playExpect(deleteButton).toBeEnabled();
+    await playExpect.poll(async () => await deleteButton.isEnabled(), { timeout: 10_000 }).toBeTruthy();
     await deleteButton.focus();
     await deleteButton.click();
     await this.page.waitForTimeout(1_000);
     await handleConfirmationDialog(this.page, podmanAILabExtension.extensionName, true, 'Confirm');
+    await playExpect.poll(async () => await this.isModelDownloaded(modelName), { timeout: 30_000 }).toBeFalsy();
+  }
+
+  async deleteAllModels(): Promise<void> {
+    const modelRows = await this.getAllModelRows();
+    if (modelRows.length === 0) {
+      return;
+    }
+
+    for (const modelRow of modelRows) {
+      const modelName = await this.getModelNameByRow(modelRow);
+      if (await this.isModelDownloaded(modelName)) {
+        await this.deleteModel(modelName);
+      }
+    }
   }
 
   async isModelDownloaded(modelName: string): Promise<boolean> {