Skip to content

Commit ac99c7c

Browse files
build(deps-dev): bump eslint-plugin-svelte from 3.5.1 to 3.6.0 (#3000)
* build(deps-dev): bump eslint-plugin-svelte from 3.5.1 to 3.6.0 Bumps [eslint-plugin-svelte](https://github.com/sveltejs/eslint-plugin-svelte) from 3.5.1 to 3.6.0. - [Release notes](https://github.com/sveltejs/eslint-plugin-svelte/releases) - [Commits](https://github.com/sveltejs/eslint-plugin-svelte/compare/[email protected]@3.6.0) --- updated-dependencies: - dependency-name: eslint-plugin-svelte dependency-version: 3.6.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * fix: use $derived instead of writable state (#3014) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jeff MAURY <[email protected]>
1 parent bd0e5d7 commit ac99c7c

File tree

3 files changed

+15
-29
lines changed

3 files changed

+15
-29
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
"eslint-plugin-redundant-undefined": "^1.0.0",
6262
"eslint-plugin-simple-import-sort": "^12.1.1",
6363
"eslint-plugin-sonarjs": "^3.0.2",
64-
"eslint-plugin-svelte": "^3.5.1",
64+
"eslint-plugin-svelte": "^3.6.0",
6565
"eslint-plugin-unicorn": "^59.0.1",
6666
"globals": "^16.1.0",
6767
"husky": "^9.1.7",

packages/frontend/src/pages/NewInstructLabSession.svelte

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,17 +12,14 @@ import type { ModelInfo } from '@shared/models/IModelInfo';
1212
let skillsFiles: string[] = $state([]);
1313
let knowledgeFiles: string[] = $state([]);
1414
15-
let valid: boolean = $state(false);
16-
17-
let sessionName: string = $state('');
1815
let model: ModelInfo | undefined = $state(undefined);
16+
let sessionName: string = $state('');
17+
let valid: boolean = $derived(
18+
(skillsFiles.length > 0 || knowledgeFiles.length > 0) && !!model && sessionName.length > 0,
19+
);
1920
2021
let trainingType: 'knowledge' | 'skills' = $state('knowledge');
2122
22-
$effect(() => {
23-
valid = (skillsFiles.length > 0 || knowledgeFiles.length > 0) && !!model && sessionName.length > 0;
24-
});
25-
2623
function goToUpPage(): void {
2724
router.goto('/tune');
2825
}

pnpm-lock.yaml

Lines changed: 10 additions & 21 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)