Skip to content

Commit 0fb7890

Browse files
committed
Revert "Instrument cleanup tracer to log weird volume removal flake"
This reverts commit d633824. The issue has been fixed in commit 9a0c0b2 and I have not seen it since so remove this special case. Signed-off-by: Paul Holzinger <[email protected]>
1 parent 0be44cc commit 0fb7890

File tree

2 files changed

+1
-16
lines changed

2 files changed

+1
-16
lines changed

hack/podman_cleanup_tracer.bt

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -149,17 +149,3 @@ tracepoint:syscalls:sys_enter_write
149149
$offset += $len
150150
}
151151
}
152-
153-
// HACK: debug for https://github.com/containers/podman/issues/23913
154-
// The test uses "ebpf-debug-23913" volume name and because and volume rm
155-
// will delete the path we can trap the process here to find out who actually
156-
// deletes it.
157-
tracepoint:syscalls:sys_enter_unlink*
158-
/ strcontains(str(args.pathname), "ebpf-debug-23913") /
159-
{
160-
printf("Special issue 23913 volume deleted by pid %d: ", pid);
161-
// This can fail to open the file it is done in user space and
162-
// thus racy if the process exits quickly.
163-
cat("/proc/%d/cmdline", pid);
164-
print("");
165-
}

test/system/600-completion.bats

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -270,8 +270,7 @@ function _check_no_suggestions() {
270270
random_image_name="i-$(safename)"
271271
random_image_tag=$(random_string 5)
272272
random_network_name="n-$(safename)"
273-
# Do not change the suffix, it is special debug for #23913
274-
random_volume_name="v-$(safename)-ebpf-debug-23913"
273+
random_volume_name="v-$(safename)"
275274
random_secret_name="s-$(safename)"
276275
random_secret_content=$(random_string 30)
277276
secret_file=$PODMAN_TMPDIR/$(random_string 10)

0 commit comments

Comments
 (0)