Skip to content

Commit 16fae26

Browse files
Merge pull request #27549 from axel7083/fix/api/compact/remove-secrets
fix(api/compact): typo in the remove secret handle
2 parents f3d38d3 + d31f4e7 commit 16fae26

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

pkg/api/server/register_secrets.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ func (s *APIServer) registerSecretHandlers(r *mux.Router) error {
236236
// '500':
237237
// "$ref": "#/responses/internalError"
238238
r.Handle(VersionedPath("/secrets/{name}"), s.APIHandler(compat.RemoveSecret)).Methods(http.MethodDelete)
239-
r.Handle("/secret/{name}", s.APIHandler(compat.RemoveSecret)).Methods(http.MethodDelete)
239+
r.Handle("/secrets/{name}", s.APIHandler(compat.RemoveSecret)).Methods(http.MethodDelete)
240240

241241
r.Handle(VersionedPath("/secrets/{name}/update"), s.APIHandler(compat.UpdateSecret)).Methods(http.MethodPost)
242242
r.Handle("/secrets/{name}/update", s.APIHandler(compat.UpdateSecret)).Methods(http.MethodPost)

test/apiv2/50-secrets.at

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,3 +76,11 @@ t DELETE secrets/bogus 404
7676

7777
# secret update not implemented
7878
t POST secrets/mysecret/update 501
79+
80+
# compat api
81+
t POST /secrets/create Name=foosecret Data=c2VjcmV0 200
82+
83+
t GET /secrets/foosecret 200 \
84+
.Spec.Name=foosecret
85+
86+
t DELETE /secrets/foosecret 204

0 commit comments

Comments
 (0)