Skip to content

Commit 3a2d758

Browse files
committed
remote: don't print bogus error when starting container attached
This looks like debug leftover, in any case this is not an error so simply remove the line. Fixes #25965 Signed-off-by: Paul Holzinger <[email protected]>
1 parent bc81470 commit 3a2d758

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

pkg/domain/infra/tunnel/containers.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -806,7 +806,6 @@ func (ic *ContainerEngine) ContainerStart(ctx context.Context, namesOrIds []stri
806806
logrus.Errorf("Failed to check if %s should restart: %v", ctr.ID, err)
807807
return
808808
}
809-
logrus.Errorf("Should restart: %v", shouldRestart)
810809

811810
if !shouldRestart && ctr.AutoRemove {
812811
removeContainer(ctr.ID, ctr.CIDFile)

test/system/045-start.bats

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -149,4 +149,18 @@ load helpers
149149
run_podman rm -t 0 -f $ctrID $cname
150150
}
151151

152+
# Regression test for https://github.com/containers/podman/issues/25965
153+
# bats test_tags=ci:parallel
154+
@test "podman start attach with created --rm container" {
155+
local msg=c-$(safename)
156+
run_podman create --rm $IMAGE echo "$msg"
157+
cid="$output"
158+
159+
run_podman start -a $cid
160+
assert "$output" == "$msg" "attach printed the expected output"
161+
162+
# container must be removed on its own as it was created with --rm
163+
run_podman 1 container exists $cid
164+
}
165+
152166
# vim: filetype=sh

0 commit comments

Comments
 (0)