test/apiv2: fix registry push flake

In our CI env we use a special registries.conf file
(test/registries.conf) to redirect some parts but it also defines:
[[registry]]
location="localhost:5000"
insecure=true

That means that port 5000 is trusted by default so the
/v1.40/images/localhost:5000/myrepo/push?tag=mytag test in 12-imagesMore
fails when the test registry uses port 5000.

Example failure:
not ok 360 [12-imagesMore] POST /v1.40/images/localhost:5000/myrepo/push?tag=mytag [-d {}] : status
 #  expected: 500
 #    actual: 200
 #  response: {"status":"The push refers to repository [localhost:5000/myrepo:mytag]"}
 {"status":"mytag: digest: sha256:d40f8191d6dae366339e318d1004258022f56bd8c649720a72060fad20019c9d size: 758"}

To avoid using port 5000 simply start at 5001.

Signed-off-by: Paul Holzinger <[email protected]>

Author: Luap99

test/apiv2/test-apiv2

@@ -603,10 +603,12 @@ function stop_registry() {
 }
 
 #################
-#  random_port  #  Random open port; arg is range (min-max), default 5000-5999
+#  random_port  #  Random open port; arg is range (min-max), default 5001-5999
 #################
 function random_port() {
-    local range=${1:-5000-5999}
+    # Note port 5001 is chosen because 5000 is trusted per test/registries.conf.
+    # The tests try to push without SSL and that must fail so we cannot use that port.
+    local range=${1:-5001-5999}
 
     local port
     for port in $(shuf -i ${range}); do