Skip to content

Commit df346e1

Browse files
committed
update
Signed-off-by: Lokesh Mandvekar <[email protected]>
1 parent 1d58e7e commit df346e1

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

libpod/info_linux.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,7 @@ func (r *Runtime) setPlatformHostInfo(info *define.HostInfo) error {
3030
return fmt.Errorf("getting Seccomp profile path: %w", err)
3131
}
3232

33-
// Get Map of all available controllers
34-
// FIXME: AvailableControllers should be further simplified once CGv1 removal
35-
// in container-libs is complete.
36-
availableControllers, err := cgroups.AvailableControllers(nil, true)
33+
availableControllers, err := cgroups.AvailableControllers()
3734
if err != nil {
3835
return fmt.Errorf("getting available cgroup controllers: %w", err)
3936
}

libpod/oci_conmon_linux.go

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -216,13 +216,16 @@ func (r *ConmonOCIRuntime) moveConmonToCgroupAndSignal(ctr *Container, cmd *exec
216216
logrus.StandardLogger().Logf(logLevel, "Failed to add conmon to systemd sandbox cgroup: %v", err)
217217
}
218218
} else {
219-
control, err := cgroups.New(cgroupPath, &cgroupResources)
219+
_, err := cgroups.New(cgroupPath, &cgroupResources)
220220
if err != nil {
221221
logrus.StandardLogger().Logf(logLevel, "Failed to add conmon to cgroupfs sandbox cgroup: %v", err)
222-
} else if err := control.AddPid(cmd.Process.Pid); err != nil {
223-
// we need to remove this defer and delete the cgroup once conmon exits
224-
// maybe need a conmon monitor?
225-
logrus.StandardLogger().Logf(logLevel, "Failed to add conmon to cgroupfs sandbox cgroup: %v", err)
222+
} else {
223+
// Add conmon process to the cgroup
224+
cgroupProcs := filepath.Join("/sys/fs/cgroup", cgroupPath, "cgroup.procs")
225+
pidStr := fmt.Sprintf("%d", cmd.Process.Pid)
226+
if err := os.WriteFile(cgroupProcs, []byte(pidStr), 0o644); err != nil {
227+
logrus.StandardLogger().Logf(logLevel, "Failed to add conmon to cgroupfs sandbox cgroup: %v", err)
228+
}
226229
}
227230
}
228231
}

0 commit comments

Comments
 (0)