Merge pull request #26898 from andershausding/fix_missing_content_type_header

fix: Correct order of setting up header fields for endpoint responses

Author: openshift-merge-bot[bot]

pkg/api/handlers/compat/images_push.go

@@ -120,8 +120,8 @@ func PushImage(w http.ResponseWriter, r *http.Request) {
 	statusWritten := false
 	writeStatusCode := func(code int) {
 		if !statusWritten {
-			w.WriteHeader(code)
 			w.Header().Set("Content-Type", "application/json")
+			w.WriteHeader(code)
 			flush()
 			statusWritten = true
 		}

pkg/api/handlers/libpod/containers_stats.go

@@ -76,8 +76,8 @@ func StatsContainer(w http.ResponseWriter, r *http.Request) {
 				return
 			}
 			// Write header and content type.
-			w.WriteHeader(http.StatusOK)
 			w.Header().Set("Content-Type", "application/json")
+			w.WriteHeader(http.StatusOK)
 			wroteContent = true
 		}
 

pkg/api/handlers/libpod/images.go

@@ -597,8 +597,8 @@ func CommitContainer(w http.ResponseWriter, r *http.Request) {
 	statusWritten := false
 	writeStatusCode := func(code int) {
 		if !statusWritten {
-			w.WriteHeader(code)
 			w.Header().Set("Content-Type", "application/json")
+			w.WriteHeader(code)
 			flush()
 			statusWritten = true
 		}

pkg/api/handlers/libpod/images_pull.go

@@ -152,8 +152,8 @@ func ImagesPull(w http.ResponseWriter, r *http.Request) {
 		}
 	}
 
-	w.WriteHeader(http.StatusOK)
 	w.Header().Set("Content-Type", "application/json")
+	w.WriteHeader(http.StatusOK)
 	flush()
 
 	enc := json.NewEncoder(w)

pkg/api/handlers/libpod/images_push.go

@@ -138,8 +138,8 @@ func PushImage(w http.ResponseWriter, r *http.Request) {
 		}
 	}
 
-	w.WriteHeader(http.StatusOK)
 	w.Header().Set("Content-Type", "application/json")
+	w.WriteHeader(http.StatusOK)
 	flush()
 
 	enc := json.NewEncoder(w)

pkg/api/handlers/libpod/manifests.go

@@ -451,8 +451,8 @@ func ManifestPush(w http.ResponseWriter, r *http.Request) {
 		}
 	}
 
-	w.WriteHeader(http.StatusOK)
 	w.Header().Set("Content-Type", "application/json")
+	w.WriteHeader(http.StatusOK)
 	flush()
 
 	enc := json.NewEncoder(w)

pkg/api/handlers/utils/images.go

@@ -146,8 +146,8 @@ func CompatPull(ctx context.Context, w http.ResponseWriter, runtime *libpod.Runt
 	statusWritten := false
 	writeStatusCode := func(code int) {
 		if !statusWritten {
-			w.WriteHeader(code)
 			w.Header().Set("Content-Type", "application/json")
+			w.WriteHeader(code)
 			flush()
 			statusWritten = true
 		}