Skip to content

Commit f4a0197

Browse files
Merge pull request #26176 from l0rd/win-arm64-e2e
Fix machine e2e tests to pass on ARM64 Windows too
2 parents 27fdd7f + 9872f0e commit f4a0197

File tree

3 files changed

+10
-4
lines changed

3 files changed

+10
-4
lines changed

pkg/machine/e2e/basic_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ var _ = Describe("run basic podman commands", func() {
113113
Expect(err).ToNot(HaveOccurred())
114114
Expect(volumeCreate).To(Exit(0))
115115

116-
run, err := mb.setCmd(bm.withPodmanCommand([]string{"run", "-v", "a:/test:Z", "quay.io/libpod/alpine_nginx", "true"})).run()
116+
run, err := mb.setCmd(bm.withPodmanCommand([]string{"run", "-v", "a:/test:Z", TESTIMAGE, "true"})).run()
117117
Expect(err).ToNot(HaveOccurred())
118118
Expect(run).To(Exit(0))
119119
})

pkg/machine/e2e/cp_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -357,7 +357,8 @@ var _ = Describe("run cp commands", func() {
357357
switch runtime.GOOS {
358358
case "windows":
359359
hostDirPath = filepath.ToSlash(hostDirPath)
360-
fallthrough
360+
Expect(session.errorToString()).To(Or(ContainSubstring(fmt.Sprintf("scp: open local \"%s\": No such file or directory", hostDirPath)),
361+
ContainSubstring(fmt.Sprintf("scp: open local \"%s\": Unknown error", hostDirPath))))
361362
case "darwin":
362363
Expect(session.errorToString()).To(ContainSubstring(fmt.Sprintf("scp: open local \"%s\": No such file or directory", hostDirPath)))
363364
case "linux":

winmake.ps1

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,10 +78,15 @@ function Local-Machine {
7878
);
7979
Build-Ginkgo
8080
if ($files) {
81-
$files = " --focus-file $files "
81+
$files = "--focus-file ""$files"""
82+
} elseif ($FOCUS_FILE) {
83+
$files = "--focus-file ""$FOCUS_FILE"" --silence-skips"
84+
}
85+
if ($FOCUS) {
86+
$focus = "--focus ""$FOCUS"" --silence-skips"
8287
}
8388

84-
Run-Command "./bin/ginkgo.exe -vv --tags `"$remotetags`" --timeout=90m --trace --no-color $files pkg/machine/e2e/."
89+
Run-Command "./bin/ginkgo.exe -vv --tags `"$remotetags`" --timeout=90m --trace --no-color $focus $files pkg/machine/e2e/."
8590
}
8691

8792
# Expect starting directory to be /podman

0 commit comments

Comments
 (0)