should we remove k8s.io/kubernetes dependence?

[BlackHole1]

Ref:

podman/go.mod

Line 78 in e4cdd4b

k8s.io/kubernetes v1.28.4

Currently, the official recommendation of k8s is not to use k8s.io/kubernetes directly as a go dependency. See: kubernetes/kubernetes#79384 (comment)

After the investigation, it was found that this dependency was initially introduced by #19630 PR. Currently, the entire podman project only utilizes the MappingFuncFor method once

podman/pkg/domain/infra/abi/play.go

Lines 1659 to 1667 in e4cdd4b

	func expandForKube(s *specgen.SpecGenerator) {
	mapping := expansion.MappingFuncFor(s.Env)
	for i, subCmd := range s.Entrypoint {
	s.Entrypoint[i] = expansion.Expand(subCmd, mapping)
	}
	for i, subCmd := range s.Command {
	s.Command[i] = expansion.Expand(subCmd, mapping)
	}
	}

I have also examined the implementation of this method, and it is very simple. My suggestion is to remove k8s.io/kubernetes and reimplement the MappingFuncFor method ourselves.

My discovery of this issue came about because I use Goland as my IDE, and Goland automatically runs: go list -modfile=./go.mod -m -json -mod=mod all after the project is opened. This led to the following result: