Delete container using libpod API

[ruspaul013]

Hello!
I saw a difference between libpod API and docker API. I am trying to delete the container and the anonymous volumes.

I am running a small example here.
This is the image that I used:

FROM docker.io/library/nginx:latest
VOLUME ["/var/log"]

build the image

podman build -t nginx-local:latest -f ./Dockerfile

create two container using this command

podman run -d localhost/nginx-local:latest

After the containers are created, check to see if the volumes are created

podman volume ls

To delte the container use:
libpod API

curl -XDELETE --unix-socket /run/podman/podman.sock -v  'http://d/v1.0.0/libpod/containers/8301c7d17524af24c088a7a10e0f28140c92920beb09de012b1e24f0be2541ac?force=true&v=true'

docker API

curl -XDELETE --unix-socket /run/podman/podman.sock -v  'http://d/v1.0.0/containers/f5882702f0c776f2b380704b3c66294e130d9fe3484c25c975f77558b55d94fa?force=true&v=true'

Now check again the volumes and see that only one volume is deleted. Is there a difference beetween this two or is a bug?

Podman version:

[root@container-build-rhel9 ~]# podman version
Client:       Podman Engine
Version:      5.2.2
API Version:  5.2.2
Go Version:   go1.22.9 (Red Hat 1.22.9-2.el9_5)
Built:        Tue Feb  4 03:46:22 2025
OS/Arch:      linux/amd64

[Luap99]

Looking at our code the libpod API requires the use of volumes=true not v=true

[Luap99]

podman/pkg/api/handlers/compat/containers.go

Lines 45 to 70 in e656872

	DockerVolumes bool `schema:"v"`
	LibpodVolumes bool `schema:"volumes"`
	}{
	// override any golang type defaults
	}
	if err := decoder.Decode(&query, r.URL.Query()); err != nil {
	utils.Error(w, http.StatusBadRequest, fmt.Errorf("failed to parse parameters for %s: %w", r.URL.String(), err))
	return
	}
	options := entities.RmOptions{
	Force: query.Force,
	Ignore: query.Ignore,
	}
	if utils.IsLibpodRequest(r) {
	options.Volumes = query.LibpodVolumes
	options.Timeout = query.Timeout
	options.Depend = query.Depend
	} else {
	if query.Link {
	utils.Error(w, http.StatusBadRequest, utils.ErrLinkNotSupport)
	return
	}
	options.Volumes = query.DockerVolumes
	}

[ruspaul013]

In the API docs is written'v' - https://docs.podman.io/en/latest/_static/api.html#tag/containers/operation/ContainerDeleteLibpod

Thanks for the message. I will try it.

[baude]

@Luap99 i'm cool updating the docs to reflect volumes instead of v. Do you think it would be prudent to also do something like:

diff --git a/pkg/api/handlers/compat/containers.go b/pkg/api/handlers/compat/containers.go
index e6fae78e84..06adc37c53 100644
--- a/pkg/api/handlers/compat/containers.go
+++ b/pkg/api/handlers/compat/containers.go
@@ -59,6 +59,11 @@ func RemoveContainer(w http.ResponseWriter, r *http.Request) {
        }
        if utils.IsLibpodRequest(r) {
                options.Volumes = query.LibpodVolumes
+               // We had a mistake in our docs where v from the docker compat API was
+               // the published bool for volumes.  We now honor either.
+               if query.DockerVolumes || query.LibpodVolumes {
+                       options.Volumes = false
+               }
                options.Timeout = query.Timeout
                options.Depend = query.Depend
        } else {

[Luap99]

I rather just fix the docs