updated default benchmarks path logic

Signed-off-by: Ian Eaves <ian.k.eaves@gmail.com>

Author: ieaves

docs/ramalama.conf

@@ -214,11 +214,12 @@
 #
 
 [ramalama.benchmarks]
-#storage_folder = <conf dir>/benchmarks
+#storage_folder = <default store>/benchmarks
 #
 # Manually specify where to save benchmark results.
-# By default, this will be stored in the default configuration
-# directory for your platform as benchmarks.jsonl.
+# By default, results are stored under the default model store directory
+# in benchmarks/benchmarks.jsonl.
+# Changing `ramalama.store` does not update this; set storage_folder explicitly.
 
 
 [ramalama.user]

docs/ramalama.conf.5.md

@@ -258,11 +258,11 @@ The ramalama.benchmarks table contains benchmark related settings.
 
 `[[ramalama.benchmarks]]`
 
-**storage_folder**="<conf dir>/benchmarks"
+**storage_folder**="<default store>/benchmarks"
 
 Manually specify where to save benchmark results.
-By default, this will be stored in the default configuration
-directory for your platform as `benchmarks.jsonl`.
+By default, this will be stored in the default model store directory under `benchmarks/`.
+Changing `ramalama.store` does not update this; set `ramalama.benchmarks.storage_folder` explicitly if needed.
 
 ## RAMALAMA.USER TABLE
 The ramalama.user table contains user preference settings.

ramalama/config.py

@@ -2,6 +2,7 @@
 import os
 import sys
 from dataclasses import dataclass, field, fields
+from functools import lru_cache
 from pathlib import Path
 from typing import Any, Literal, Mapping, TypeAlias
 
@@ -79,6 +80,7 @@ def get_default_engine() -> SUPPORTED_ENGINES | None:
     return "docker" if available("docker") else None
 
 
+@lru_cache(maxsize=1)
 def get_default_store() -> str:
     # Check if running as root (Unix only)
     if hasattr(os, 'geteuid') and os.geteuid() == 0:
@@ -136,24 +138,21 @@ def coerce_to_bool(value: Any) -> bool:
     raise ValueError(f"Cannot coerce {value!r} to bool")
 
 
-def get_default_benchmarks_storage_folder() -> Path:
-    conf_dir = None
-    for dir in DEFAULT_CONFIG_DIRS:
-        if os.path.exists(dir):
-            conf_dir = dir
-            break
+def get_storage_folder(base_path: str | None = None):
+    if base_path is None:
+        base_path = get_default_store()
 
-    if conf_dir is not None:
-        return conf_dir / "benchmarks"
-
-    return DEFAULT_CONFIG_DIRS[0]
+    return os.path.join(base_path, "benchmarks")
 
 
 @dataclass
 class Benchmarks:
-    storage_folder: Path = field(default_factory=get_default_benchmarks_storage_folder)
+    storage_folder: str = field(default_factory=get_storage_folder)
     disable: bool = False
 
+    def __post_init__(self):
+        os.makedirs(self.storage_folder, exist_ok=True)
+
 
 @dataclass
 class UserConfig:

ramalama/transports/base.py

@@ -2,7 +2,6 @@
 import os
 import platform
 import random
-import shlex
 import socket
 import subprocess
 import sys

test/unit/test_config.py

@@ -143,6 +143,7 @@ def test_env_overrides_file_and_default():
     ],
 )
 def test_get_default_store(uid, is_root, expected):
+    get_default_store.cache_clear()
     with patch("os.geteuid", return_value=uid):
         assert get_default_store() == expected