Merge pull request #2334 from mikebonnet/konflux-e2e-fix-tmpdir

e2e: create TEMP_DIR when script is run on the VM

Author: olliewalsh

.codespelldict

@@ -20,4 +20,3 @@ specicifed->specified
 unsuppored->unsupported
 neather->neither
 registires->registries
-behavior->behaviour

.tekton/integration/tasks/test-vm-cmd.yaml

@@ -112,15 +112,14 @@ spec:
       fi
       podman pull $TEST_IMAGE
 
-      TEMP_DIR=$(mktemp -d -p /var/tmp e2e-test.XXXXXX)
-      trap 'rm -rf "$TEMP_DIR"' EXIT
+      TEMP_DIR=\$(mktemp -d -p \$PWD e2e-test.XXXXXX)
 
       podman run \
       --userns=keep-id \
       --security-opt label=disable \
       --security-opt unmask=/proc/* \
       --device /dev/net/tun \
-      -v "${TEMP_DIR}":/tmp \
+      -v \$TEMP_DIR:/tmp \
       \${EXTRA_ARGS[*]} \
       ${PODMAN_ENV[*]} \
       $TEST_IMAGE $TEST_CMD

test/e2e/test_serve.py

@@ -734,6 +734,10 @@ def test_serve_api(caplog):
 @skip_if_gh_actions_darwin
 def test_serve_with_non_existing_images():
     with RamalamaExecWorkspace() as ctx:
+        # If the requested model is missing, "ramalama serve --pull never" will exit with
+        # "Error: <model> does not exist" and returncode 22. To test the behavior of a
+        # non-existent image reference, the requested model must already be available locally.
+        ctx.check_call(["ramalama", "pull", "tiny"])
         with pytest.raises(CalledProcessError) as exc_info:
             ctx.check_output(["ramalama", "serve", "--image", "bogus", "--pull", "never", "tiny"], stderr=STDOUT)
         assert exc_info.value.returncode == 125