Skip to content

Commit 2c499ef

Browse files
fix(c2pa-web): change the unregister token passed to FinalizationRegistry.register (#28)
* fix(c2pa-web): change the unregister token passed to FinalizationRegistry.register * add changeset * fix(ci): fix flakiness (#29) * ci: install clippy * ci: run playwright install in c2pa-web dir --------- Co-authored-by: Eli Mensch <mensch@adobe.com>
1 parent 59836bb commit 2c499ef

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@contentauth/c2pa-web': patch
3+
---
4+
5+
Fix issue which crashes reader.fromBlob() and reader.fromBlobFragment() in Firefox.

packages/c2pa-web/src/lib/reader.ts

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -118,11 +118,10 @@ export function createReaderFactory(worker: WorkerManager): ReaderFactory {
118118
args: [format, blob],
119119
});
120120

121-
const unregisterToken = Symbol(readerId);
122121
const reader = createReader(worker, readerId, () => {
123-
registry.unregister(unregisterToken);
122+
registry.unregister(reader);
124123
});
125-
registry.register(reader, readerId, unregisterToken);
124+
registry.register(reader, readerId, reader);
126125

127126
return reader;
128127
},
@@ -141,11 +140,10 @@ export function createReaderFactory(worker: WorkerManager): ReaderFactory {
141140
args: [format, init, fragment],
142141
});
143142

144-
const unregisterToken = Symbol(readerId);
145143
const reader = createReader(worker, readerId, () => {
146-
registry.unregister(unregisterToken);
144+
registry.unregister(reader);
147145
});
148-
registry.register(reader, readerId, unregisterToken);
146+
registry.register(reader, readerId, reader);
149147

150148
return reader;
151149
},

0 commit comments

Comments
 (0)