Skip to content

Commit 66dcc5d

Browse files
committed
Add: COSE signing TODOs
1 parent 485f9e0 commit 66dcc5d

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

js-src/types.d.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,10 @@ export interface JsCallbackSignerConfig {
153153
tsaUrl?: string;
154154
tsaHeaders?: Array<[string, string]>;
155155
tsaBody?: Buffer;
156+
// TODO: directCoseHandling is currently not implemented in the signing logic.
157+
// The field is read from config but the actual signing implementation does not
158+
// differentiate between directCoseHandling: true/false - both cases pass the
159+
// same data to the JavaScript callback regardless of this setting.
156160
directCoseHandling: boolean;
157161
}
158162

src/neon_signer.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -321,6 +321,10 @@ impl AsyncSigner for NeonCallbackSigner {
321321
}
322322

323323
fn direct_cose_handling(&self) -> bool {
324+
// TODO: The direct_cose_handling field is currently not used in the signing logic.
325+
// The field is read from config and exposed via this getter, but the actual signing
326+
// implementation does not differentiate between directCoseHandling: true/false.
327+
// Both cases pass the same data to the JavaScript callback regardless of this setting.
324328
self.config.direct_cose_handling
325329
}
326330
}

0 commit comments

Comments
 (0)