fix: Clean up tests

Author: tmathern

tests/test_unit_tests.py

@@ -36,9 +36,9 @@ def setUp(self):
 
     def test_stream_read(self):
         with open(self.testPath, "rb") as file:
-            reader = Reader("image/jpeg",file)
-            json = reader.json()
-            self.assertIn("C.jpg", json)
+            reader = Reader("image/jpeg", file)
+            json_data = reader.json()
+            self.assertIn("C.jpg", json_data)
 
     def test_stream_read_and_parse(self):
         with open(self.testPath, "rb") as file:
@@ -49,7 +49,7 @@ def test_stream_read_and_parse(self):
 
     def test_json_decode_err(self):
         with self.assertRaises(Error.Io):
-            manifest_store = Reader("image/jpeg","foo")
+            manifest_store = Reader("image/jpeg", "foo")
 
     def test_reader_bad_format(self):
         with self.assertRaises(Error.NotSupported):
@@ -59,16 +59,18 @@ def test_reader_bad_format(self):
     def test_settings_trust(self):
         #load_settings_file("tests/fixtures/settings.toml")
         with open(self.testPath, "rb") as file:
-            reader = Reader("image/jpeg",file)
-            json = reader.json()
-            self.assertIn("C.jpg", json)
+            reader = Reader("image/jpeg", file)
+            json_data = reader.json()
+            self.assertIn("C.jpg", json_data)
 
 class TestBuilder(unittest.TestCase):
     def setUp(self):
         # Use the fixtures_dir fixture to set up paths
         self.data_dir = os.path.join(os.path.dirname(__file__), "fixtures")
-        self.certs = open(os.path.join(self.data_dir, "es256_certs.pem"), "rb").read()
-        self.key = open(os.path.join(self.data_dir, "es256_private.key"), "rb").read()
+        with open(os.path.join(self.data_dir, "es256_certs.pem"), "rb") as cert_file:
+            self.certs = cert_file.read()
+        with open(os.path.join(self.data_dir, "es256_private.key"), "rb") as key_file:
+            self.key = key_file.read()
 
         # Create a local Ps256 signer with certs and a timestamp server
         self.signer_info = C2paSignerInfo(
@@ -118,6 +120,7 @@ def test_streams_sign(self):
             json_data = reader.json()
             self.assertIn("Python Test", json_data)
             self.assertNotIn("validation_status", json_data)
+            output.close()
 
     def test_archive_sign(self):
         with open(self.testPath, "rb") as file:
@@ -132,6 +135,8 @@ def test_archive_sign(self):
             json_data = reader.json()
             self.assertIn("Python Test", json_data)
             self.assertNotIn("validation_status", json_data)
+            archive.close()
+            output.close()
 
     def test_remote_sign(self):
         with open(self.testPath, "rb") as file:
@@ -144,6 +149,7 @@ def test_remote_sign(self):
             json_data = reader.json()
             self.assertIn("Python Test", json_data)
             self.assertNotIn("validation_status", json_data)
+            output.close()
 
 if __name__ == '__main__':
     unittest.main()