Skip to content

Commit 62e2d0f

Browse files
committed
fix: Improve logging
1 parent 5026a0d commit 62e2d0f

File tree

1 file changed

+18
-3
lines changed

1 file changed

+18
-3
lines changed

src/c2pa/c2pa.py

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -865,6 +865,7 @@ def sign_file(
865865
try:
866866
os.remove(dest_path)
867867
except OSError:
868+
logger.warning("Failed to remove destination file")
868869
pass # Ignore cleanup errors
869870

870871
# Re-raise the error
@@ -1116,8 +1117,8 @@ def __del__(self):
11161117
try:
11171118
_lib.c2pa_release_stream(self._stream)
11181119
except Exception:
1119-
# Destructors shouldn't raise exceptions, just log
1120-
# silently
1120+
# Destructors shouldn't raise exceptions
1121+
logger.warning("Failed to release Stream")
11211122
pass
11221123
finally:
11231124
self._stream = None
@@ -1499,6 +1500,9 @@ def _cleanup_resources(self):
14991500
_lib.c2pa_reader_free(self._reader)
15001501
except Exception:
15011502
# Cleanup failure doesn't raise exceptions
1503+
logger.warning(
1504+
"Failed to free native Reader resources"
1505+
)
15021506
pass
15031507
finally:
15041508
self._reader = None
@@ -1509,16 +1513,18 @@ def _cleanup_resources(self):
15091513
self._own_stream.close()
15101514
except Exception:
15111515
# Cleanup failure doesn't raise exceptions
1516+
logger.warning("Failed to close Reader stream")
15121517
pass
15131518
finally:
15141519
self._own_stream = None
15151520

1516-
# Clean up backing file
1521+
# Clean up backing file (if needed)
15171522
if self._backing_file:
15181523
try:
15191524
self._backing_file.close()
15201525
except Exception:
15211526
# Cleanup failure doesn't raise exceptions
1527+
logger.warning("Failed to close Reader backing file")
15221528
pass
15231529
finally:
15241530
self._backing_file = None
@@ -1819,6 +1825,9 @@ def _cleanup_resources(self):
18191825
_lib.c2pa_signer_free(self._signer)
18201826
except Exception:
18211827
# Cleanup failure doesn't raise exceptions
1828+
logger.warning(
1829+
"Failed to free C2PA Signer during cleanup"
1830+
)
18221831
pass
18231832
finally:
18241833
self._signer = None
@@ -2372,6 +2381,9 @@ def _sign_internal(
23722381
_lib.c2pa_manifest_bytes_free(manifest_bytes_ptr)
23732382
except Exception:
23742383
# Ignore errors during cleanup
2384+
logger.warning(
2385+
"Failed to release native manifest bytes memory"
2386+
)
23752387
pass
23762388

23772389
return manifest_bytes
@@ -2483,6 +2495,9 @@ def _cleanup_resources(self):
24832495
_lib.c2pa_builder_free(self._builder)
24842496
except Exception:
24852497
# Log cleanup errors but don't raise exceptions
2498+
logger.warning(
2499+
"Failed to release native Builder resources"
2500+
)
24862501
pass
24872502
finally:
24882503
# Always clear the pointer and mark as closed

0 commit comments

Comments
 (0)