Skip to content

Commit f15d98e

Browse files
committed
fix: Review comments
1 parent 36530ab commit f15d98e

File tree

1 file changed

+8
-29
lines changed

1 file changed

+8
-29
lines changed

tests/test_unit_tests.py

Lines changed: 8 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -743,7 +743,6 @@ def setUp(self):
743743

744744
# Define a V2 manifest as a dictionary
745745
self.manifestDefinitionV2 = {
746-
"claim_generator": "python_test",
747746
"claim_generator_info": [{
748747
"name": "python_test",
749748
"version": "0.0.1",
@@ -2326,12 +2325,9 @@ def test_builder_state_with_invalid_native_pointer(self):
23262325

23272326
def test_builder_add_action_to_manifest_no_auto_add(self):
23282327
# For testing, remove auto-added actions
2329-
load_settings('{"builder":{"actions":{"auto_placed_action":{"enabled":false}}}}')
2330-
load_settings('{"builder":{"actions":{"auto_opened_action":{"enabled":false}}}}')
2331-
load_settings('{"builder":{"actions":{"auto_created_action":{"enabled":false}}}}')
2328+
load_settings('{"builder":{"actions":{"auto_placed_action":{"enabled":false},"auto_opened_action":{"enabled":false},"auto_created_action":{"enabled":false}}}}')
23322329

23332330
initial_manifest_definition = {
2334-
"claim_generator": "python_test",
23352331
"claim_generator_info": [{
23362332
"name": "python_test",
23372333
"version": "0.0.1",
@@ -2340,7 +2336,6 @@ def test_builder_add_action_to_manifest_no_auto_add(self):
23402336
# "claim_version": 2,
23412337
"format": "image/jpeg",
23422338
"title": "Python Test Image V2",
2343-
"ingredients": [],
23442339
"assertions": [
23452340
{
23462341
"label": "c2pa.actions",
@@ -2406,18 +2401,13 @@ def test_builder_add_action_to_manifest_no_auto_add(self):
24062401
builder.close()
24072402

24082403
# Reset settings
2409-
load_settings('{"builder":{"actions":{"auto_placed_action":{"enabled":true}}}}')
2410-
load_settings('{"builder":{"actions":{"auto_opened_action":{"enabled":true}}}}')
2411-
load_settings('{"builder":{"actions":{"auto_created_action":{"enabled":true}}}}')
2404+
load_settings('{"builder":{"actions":{"auto_placed_action":{"enabled":true},"auto_opened_action":{"enabled":true},"auto_created_action":{"enabled":true}}}}')
24122405

24132406
def test_builder_add_action_to_manifest_with_auto_add(self):
24142407
# For testing, force settings
2415-
load_settings('{"builder":{"actions":{"auto_placed_action":{"enabled":true}}}}')
2416-
load_settings('{"builder":{"actions":{"auto_opened_action":{"enabled":true}}}}')
2417-
load_settings('{"builder":{"actions":{"auto_created_action":{"enabled":true}}}}')
2408+
load_settings('{"builder":{"actions":{"auto_placed_action":{"enabled":true},"auto_opened_action":{"enabled":true},"auto_created_action":{"enabled":true}}}}')
24182409

24192410
initial_manifest_definition = {
2420-
"claim_generator": "python_test",
24212411
"claim_generator_info": [{
24222412
"name": "python_test",
24232413
"version": "0.0.1",
@@ -2500,15 +2490,11 @@ def test_builder_add_action_to_manifest_with_auto_add(self):
25002490
builder.close()
25012491

25022492
# Reset settings to default
2503-
load_settings('{"builder":{"actions":{"auto_placed_action":{"enabled":true}}}}')
2504-
load_settings('{"builder":{"actions":{"auto_opened_action":{"enabled":true}}}}')
2505-
load_settings('{"builder":{"actions":{"auto_created_action":{"enabled":true}}}}')
2493+
load_settings('{"builder":{"actions":{"auto_placed_action":{"enabled":true},"auto_opened_action":{"enabled":true},"auto_created_action":{"enabled":true}}}}')
25062494

25072495
def test_builder_minimal_manifest_add_actions_and_sign_no_auto_add(self):
25082496
# For testing, remove auto-added actions
2509-
load_settings('{"builder":{"actions":{"auto_placed_action":{"enabled":false}}}}')
2510-
load_settings('{"builder":{"actions":{"auto_opened_action":{"enabled":false}}}}')
2511-
load_settings('{"builder":{"actions":{"auto_created_action":{"enabled":false}}}}')
2497+
load_settings('{"builder":{"actions":{"auto_placed_action":{"enabled":false},"auto_opened_action":{"enabled":false},"auto_created_action":{"enabled":false}}}}')
25122498

25132499
initial_manifest_definition = {
25142500
"claim_generator": "python_test",
@@ -2569,18 +2555,13 @@ def test_builder_minimal_manifest_add_actions_and_sign_no_auto_add(self):
25692555
builder.close()
25702556

25712557
# Reset settings
2572-
load_settings('{"builder":{"actions":{"auto_placed_action":{"enabled":true}}}}')
2573-
load_settings('{"builder":{"actions":{"auto_opened_action":{"enabled":true}}}}')
2574-
load_settings('{"builder":{"actions":{"auto_created_action":{"enabled":true}}}}')
2558+
load_settings('{"builder":{"actions":{"auto_placed_action":{"enabled":true},"auto_opened_action":{"enabled":true},"auto_created_action":{"enabled":true}}}}')
25752559

25762560
def test_builder_minimal_manifest_add_actions_and_sign_with_auto_add(self):
25772561
# For testing, remove auto-added actions
2578-
load_settings('{"builder":{"actions":{"auto_placed_action":{"enabled":true}}}}')
2579-
load_settings('{"builder":{"actions":{"auto_opened_action":{"enabled":true}}}}')
2580-
load_settings('{"builder":{"actions":{"auto_created_action":{"enabled":true}}}}')
2562+
load_settings('{"builder":{"actions":{"auto_placed_action":{"enabled":true},"auto_opened_action":{"enabled":true},"auto_created_action":{"enabled":true}}}}')
25812563

25822564
initial_manifest_definition = {
2583-
"claim_generator": "python_test",
25842565
"claim_generator_info": [{
25852566
"name": "python_test",
25862567
"version": "0.0.1",
@@ -2648,9 +2629,7 @@ def test_builder_minimal_manifest_add_actions_and_sign_with_auto_add(self):
26482629
builder.close()
26492630

26502631
# Reset settings
2651-
load_settings('{"builder":{"actions":{"auto_placed_action":{"enabled":true}}}}')
2652-
load_settings('{"builder":{"actions":{"auto_opened_action":{"enabled":true}}}}')
2653-
load_settings('{"builder":{"actions":{"auto_created_action":{"enabled":true}}}}')
2632+
load_settings('{"builder":{"actions":{"auto_placed_action":{"enabled":true},"auto_opened_action":{"enabled":true},"auto_created_action":{"enabled":true}}}}')
26542633

26552634

26562635
class TestStream(unittest.TestCase):

0 commit comments

Comments
 (0)