feat: Add CAWG validation to `Reader` #1370

scouten-adobe · 2025-09-02T22:54:36Z

This is a sketch of the changes I'd like to see made to the Reader interface to make CAWG more directly part of the reading process from clients' point of view.

…n't find it yet

…uten/cai-9212-add-cawg-to-reader

codecov · 2025-09-02T22:56:34Z

Codecov Report

❌ Patch coverage is 82.79570% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.44%. Comparing base (f746613) to head (bbebf93).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
sdk/src/reader.rs	38.09%	13 Missing ⚠️
sdk/src/identity/identity_assertion/assertion.rs	83.33%	1 Missing ⚠️
sdk/src/manifest_store_report.rs	0.00%	1 Missing ⚠️
sdk/src/validation_status.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1370      +/-   ##
==========================================
+ Coverage   78.41%   78.44%   +0.02%     
==========================================
  Files         162      162              
  Lines       39536    39593      +57     
==========================================
+ Hits        31001    31057      +56     
- Misses       8535     8536       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

c2pa_c_ffi/src/c_api.rs

sdk/examples/cawg_identity.rs

sdk/src/reader.rs

codspeed-hq · 2025-09-11T23:06:08Z

CodSpeed Performance Report

Merging #1370 will not alter performance

_{Comparing scouten/cai-9212-add-cawg-to-reader (bbebf93) with main (f746613)}

Summary

✅ 16 untouched
⏩ 2 skipped¹

2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

…ed and where

scouten-adobe · 2025-09-12T21:51:36Z

I think I've solved the sync/async issues by leaving the existing approach in C API unchanged. I've added a new convenience function (async only) which does the combined test. That's what we were doing in the C API wrapper functions already and I've removed my changes to those functions.

sdk/src/reader.rs

gpeacock

Why not just say that Reader::from_stream_async() supports cawg but reader_from_stream() doesn't yet. The same would go for Reader:from_file() I don't see why we should add new cawg specific methods here.
Eventually, hopefully the sync methods can support cawg too.

Another option is that we can configure the cawg support with a setting. So if you have cawg enabled we always do the cawg call and if you don't there's no extra overhead.

Maybe there's a separate (or the same) option that allows the sync methods to block on the async call. you can can disable the setting if you don't want that behavior.

sdk/src/reader.rs

c2pa_c_ffi/src/c_api.rs

sdk/src/reader.rs

scouten-adobe · 2025-09-17T16:37:52Z

TO DO: Review c2patool usage.

scouten-adobe · 2025-09-17T16:40:29Z

TO DO: Check in to whether verify-on-sign does CAWG identity assertion verification and if it becomes async as a result.

…ifest`

…ies whether to interpret identity assertions during manifest reading Defaults to true, but there are some internal tests that need it off.

These were public but undocumented. Encouraging external clients to use the new JSON-style reporting added in this PR.

scouten-adobe · 2025-10-07T20:52:53Z

sdk/src/identity/identity_assertion/assertion.rs

    ///
    /// Aside from CBOR parsing, no further validation is performed.
-    pub fn from_manifest<'a>(
+    pub(crate) fn from_manifest<'a>(


@emensch @tmathern please review these access changes and LMK if any of these need to remain public.

From my point of view the access changes are OK.

Can the fields of IdentityAssertion above be public, or can I have a more general constructor? I redefine it in the Node SDK, which is not a good practice.
https://github.com/contentauth/c2pa-node-v2/blob/main/src/neon_identity_assertion_builder.rs#L34

sdk/src/manifest.rs

tmathern

Can you give the image a better name than cawgi? What is special about it, except that it has cawg data?

emensch

LGTM! Very excited to get this in.

scouten-adobe added 3 commits August 5, 2025 13:35

TDD: Test that expects a success code for identity assertion but does…

41d19ae

…n't find it yet

Sketch in proposed changes for CAWG validation in Reader interface

ac8acc1

Merge branch 'scouten/cai-9212-identity-assertion-in-reader' into sco…

61c2ced

…uten/cai-9212-add-cawg-to-reader

scouten-adobe requested a review from gpeacock September 2, 2025 22:54

scouten-adobe self-assigned this Sep 2, 2025

tmathern reviewed Sep 3, 2025

View reviewed changes

c2pa_c_ffi/src/c_api.rs Outdated Show resolved Hide resolved

sdk/examples/cawg_identity.rs Show resolved Hide resolved

sdk/src/reader.rs Outdated Show resolved Hide resolved

Merge branch 'main' into scouten/cai-9212-add-cawg-to-reader

adc1715

emensch mentioned this pull request Sep 9, 2025

Add c2pa-types + typed activeManifest and manifestStore APIs contentauth/c2pa-js#11

Merged

Merge branch 'main' into scouten/cai-9212-add-cawg-to-reader

650d954

scouten-adobe changed the title ~~Add CAWG validation to reader~~ feat: Add CAWG validation to reader Sep 11, 2025

Remove unused import

d8c04e3

scouten-adobe added 2 commits September 11, 2025 16:07

Getting back into this project; a little more clarity on what is need…

faf671b

…ed and where

Clean up test noise now that I know where I need to place updates

0f90e21

scouten-adobe changed the title ~~feat: Add CAWG validation to reader~~ feat: Add CAWG validation to Reader Sep 12, 2025

Hmmm … maybe this doesn't need to be so complicated

5270494

scouten-adobe force-pushed the scouten/cai-9212-add-cawg-to-reader branch from ba322ff to 5270494 Compare September 12, 2025 21:44

scouten-adobe marked this pull request as ready for review September 12, 2025 21:50

"Fix" WASI build errors

c7928b8

tmathern requested a review from emensch September 12, 2025 22:03

scouten-adobe commented Sep 12, 2025

View reviewed changes

sdk/src/reader.rs Outdated Show resolved Hide resolved

tmathern approved these changes Sep 12, 2025

View reviewed changes

sdk/src/reader.rs Outdated Show resolved Hide resolved

emensch reviewed Sep 12, 2025

View reviewed changes

sdk/src/reader.rs Outdated Show resolved Hide resolved

gpeacock requested changes Sep 12, 2025

View reviewed changes

sdk/src/reader.rs Outdated Show resolved Hide resolved

c2pa_c_ffi/src/c_api.rs Show resolved Hide resolved

scouten-adobe commented Sep 17, 2025

View reviewed changes

sdk/src/reader.rs Outdated Show resolved Hide resolved

Merge branch 'main' into scouten/cai-9212-add-cawg-to-reader

ccb6038

gpeacock and others added 9 commits September 18, 2025 23:55

feat: cawg in native Reader

25d029f

Merge branch 'main' into scouten/cai-9212-add-cawg-to-reader

c87e7f5

Reader::from_stream_async should use Store::from_store_async

aeab1bc

Merge branch 'main' into scouten/cai-9212-add-cawg-to-reader

13523aa

Plan to resolve compatibility issues for `IdentityAssertion::from_man…

a612b45

…ifest`

Merge branch 'main' into scouten/cai-9212-add-cawg-to-reader

ad03081

Add new settings value (core.decode_identity_assertions) which specif…

1d4b79f

…ies whether to interpret identity assertions during manifest reading Defaults to true, but there are some internal tests that need it off.

Downgrade most IdentityAssertion APIs to pub(crate)

909ba26

These were public but undocumented. Encouraging external clients to use the new JSON-style reporting added in this PR.

Update CAWG signing example

5178230

scouten-adobe commented Oct 7, 2025

View reviewed changes

scouten-adobe added 6 commits October 7, 2025 13:54

TO DO is only relevant if API becomes public again

c9df434

Retool this test to be properly async

4622847

Retool this test to be more sync

316091e

Add missing doc links

0ab0e53

Remove commented-out code

33aab39

cargo fmt

c51180b

tmathern reviewed Oct 7, 2025

View reviewed changes

sdk/src/manifest.rs Outdated Show resolved Hide resolved

tmathern approved these changes Oct 7, 2025

View reviewed changes

emensch approved these changes Oct 8, 2025

View reviewed changes

scouten-adobe added 2 commits October 8, 2025 09:39

Merge branch 'main' into scouten/cai-9212-add-cawg-to-reader

8bebd11

Remove dbg!

bbebf93

feat: Add CAWG validation to Reader #1370

Are you sure you want to change the base?

feat: Add CAWG validation to Reader #1370

Conversation

scouten-adobe commented Sep 2, 2025

Uh oh!

codecov bot commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codspeed-hq bot commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #1370 will not alter performance

Summary

Footnotes

Uh oh!

scouten-adobe commented Sep 12, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gpeacock left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

scouten-adobe commented Sep 17, 2025

Uh oh!

scouten-adobe commented Sep 17, 2025

Uh oh!

scouten-adobe Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

tmathern Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

cdmurph32 Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tmathern left a comment

Choose a reason for hiding this comment

Uh oh!

emensch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

feat: Add CAWG validation to `Reader` #1370

feat: Add CAWG validation to `Reader` #1370

codecov bot commented Sep 2, 2025 •

edited

Loading

codspeed-hq bot commented Sep 11, 2025 •

edited

Loading