Skip to content

Conversation

@emensch
Copy link
Contributor

@emensch emensch commented Oct 22, 2025

Changes in this pull request

It looks like the generic_array package (a sub-sub-dependency of sha2) is deprecated, and the latest non-rc version of sha2 (0.10.9) doesn't resolve the issue.

#1507 cannot be merged until this is fixed, so I've gone ahead and allowed the deprecated dependency here.

Tracked: #1509

Copy link
Contributor

@tmathern tmathern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint doesn't seem to be well-liked by the checks, for the PR title.

@emensch emensch changed the title lint: allow deprecated subdependency chore: allow deprecated subdependency Oct 22, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 22, 2025

CodSpeed Performance Report

Merging #1508 will not alter performance

Comparing allow-deprecated-subdependency (271b682) with main (fe49a29)

Summary

✅ 16 untouched
⏩ 2 skipped1

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@emensch emensch merged commit f9f59b2 into main Oct 22, 2025
44 of 45 checks passed
@emensch emensch deleted the allow-deprecated-subdependency branch October 22, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants