-
Notifications
You must be signed in to change notification settings - Fork 111
feat(sdk): Introduce new API to retrieve raw JUMBF manifest from C2paReader #1625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(sdk): Introduce new API to retrieve raw JUMBF manifest from C2paReader #1625
Conversation
CodSpeed Performance ReportMerging #1625 will not alter performanceComparing Summary
Footnotes
|
|
(@magaylor I merged in latest changes to re-run tests with latest main) |
…er' of https://github.com/magaylor/c2pa-rs into user/magaylor/20251120_add_raw_jumbf_extraction_to_reader
|
Please explain the workflow you want to achieve. Are you trying to save pre-validated ingredient and add them to manifests later? The right way is to add the ingredient to a Builder and then archive the builder until you need it. You then have two options, either reconstruct the builder using Builder::from_archive or you can add the archived builder as an ingredient using builder.add_ingredient_from_stream(). In this case, you can use the format "application/c2pa" and the parent ingredient in the archive will be added as the ingredient. We are changing the format of archived builders to be a single application/c2pa (.c2pa) asset instead of a zipped folder archive. |
gpeacock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It sounds like you want this to reconstruct an ingredient, but there are other ways to do that which are much safer and will add ingredients correctly. What exactly is the workflow you need here?
Adding an API to the Reader that allows clients to extract the RAW JUMBF Manifest from an asset.
This has been a feature I've been talking to @mauricefisher64 about for a month or two now. It's my understanding that contentauth is tracking this item, but internal Microsoft teams are beginning to become blocked on it not existing.
We are working on adding manifestData to ingredient assertions and have no clean way, without 3p tools, to get the Raw JUMBF manifest from the file.
Changes in this pull request
Adding raw jumbf method to the reader and exposing it to the bindings code.
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.