Skip to content

Commit 34e6196

Browse files
committed
add review comment
1 parent 0170bdc commit 34e6196

File tree

3 files changed

+17
-3
lines changed

3 files changed

+17
-3
lines changed

docs/manifest/reading/legacy.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ Old manifests may contain these kinds of deprecated ingredient data:
1111
- V1 ingredients, with label `c2pa.ingredient`.
1212
- V2 ingredients, with label `c2pa.ingredient.v2`.
1313

14-
<a name="question"></a>
14+
<a name="question1"></a>
1515

1616
<div class="review-comment">
1717
What should we say about reading v1 and v2 ingredients?
@@ -21,6 +21,8 @@ What should we say about reading v1 and v2 ingredients?
2121

2222
Existing manifests may contain two versions of actions: original v1 actions, with label `c2pa.actions`, and revised v2 actions, with label `c2pa.actions.v2`. While a v1 action is fully specified in its actions array, a v2 action may either be fully specified in an element of the actions array or it may be derived from an element in the templates array with the same action name.
2323

24+
<a name="question2"></a>
25+
2426
<div class="review-comment">
2527
What should we say about reading v1 actions?
2628
</div>

docs/manifest/reading/validation.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,14 @@ title: Validating manifests
55

66
Processing an asset includes [validating the manifests](https://c2pa.org/specifications/specifications/2.2/specs/C2PA_Specification.html#_validation) in the associated manifest store. During validation, errors can occur in the active manifest and in ingredients.
77

8+
In the latest version of the SDK,
9+
- Builder performs validation by default, so you can't create an invalid manifest. Previously, the SDK was permissive in this regard.
10+
- Validation is much stricter
11+
12+
<div class="review-comment">
13+
Need a high-level summary of full validation, what we're looking for, etc.
14+
</div>
15+
816
## Validation errors in manifests
917

1018
When you load an asset, all the manifests in the manifest store are validated and any [failure codes](https://c2pa.org/specifications/specifications/2.2/specs/C2PA_Specification.html#_failure_codes) are assigned to the `validation_status` array. Inspect the array to find the validation errors.

docs/manifest/writing/assertions-actions.md

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,16 @@ The standard form of an assertion in a JSON manifest is:
2626
]
2727
```
2828

29+
:::important
30+
Every manifest has to start with either an opened or created action, which has to be the first action in the manifest. Each of these actions need to have an associated ingredient.
31+
:::
32+
2933
### Changes from earlier releases
3034

3135
Changes include:
32-
- `c2pa.data_mining` > `cawg.data_mining`, etc. were renamed, with xref.
36+
- Old training and data mining assertions `c2pa.data_mining`, `c2pa.ai_training`, `c2pa.ai_generative_training`, and `c2pa.ai_inference` have been replaced by [CAWG training and data mining assertions](../writing/assertions-actions.md#cawg-training-and-data-mining-assertion)
3337
- `SoftwareAgent` is a [ClaimGeneratorInfo](../json-ref/manifest-def.mdx#claimgeneratorinfo) structure instead of a string.
34-
- Ingredients are now V2 ingredients
38+
- Ingredients are now V3 ingredients
3539

3640
#### V2 actions
3741

0 commit comments

Comments
 (0)