Merge pull request #4 from contentful/feat/datetime-json

Make DateTimeImmutable implement \JsonSerializable

Author: dborsatto

.travis.yml

@@ -80,7 +80,7 @@ after_success:
     # We generate API docs only for the build lead (to avoid wasting time on all builds),
     # and when on merges to master, which is the result of this condition and the setting
     # branches: only: master above.
-    if [[ ($TRAVIS_PULL_REQUEST == false || $TRAVIS_TAG != false) && $BUILD_LEAD == 1 ]]
+    if [[ ($TRAVIS_PULL_REQUEST == false || $TRAVIS_TAG != '') && $BUILD_LEAD == 1 ]]
     then
       sh ./scripts/prepare-docs.sh
     fi
@@ -91,7 +91,7 @@ deploy:
   github_token: $GITHUB_TOKEN
   local_dir: build/docs
   on:
-    condition: ($TRAVIS_PULL_REQUEST == false || $TRAVIS_TAG != false) && $BUILD_LEAD == 1
+    condition: ($TRAVIS_PULL_REQUEST == false || $TRAVIS_TAG != '') && $BUILD_LEAD == 1
 
 notifications:
   slack:

README.md

@@ -1,10 +1,10 @@
 # contentful-core.php
 
-[![Packagist](https://img.shields.io/packagist/v/contentful/contentful-core.svg?style=flat-square)](https://packagist.org/packages/contentful/contentful-core.php)
-[![Travis](https://img.shields.io/travis/contentful/contentful-core.php.svg?style=flat-square)](https://travis-ci.org/contentful/contentful-core.php)
-[![Packagist](https://img.shields.io/github/license/contentful/contentful-core.php.svg?style=flat-square)](https://packagist.org/packages/contentful/contentful-core.php)
-[![Code Climate](https://img.shields.io/codeclimate/github/contentful/contentful-core.php.svg?style=flat-square)](https://codeclimate.com/github/contentful/contentful-core.php)
-[![Codecov](https://img.shields.io/codecov/c/github/contentful/contentful-core.php.svg?style=flat-square)](https://codecov.io/gh/contentful/contentful-core.php)
+[![Packagist](https://img.shields.io/packagist/v/contentful/core.svg?style=for-the-badge)](https://packagist.org/packages/contentful/core)
+[![PHP from Packagist](https://img.shields.io/packagist/php-v/contentful/core.svg?style=for-the-badge)](https://packagist.org/packages/contentful/core)
+[![Travis](https://img.shields.io/travis/contentful/contentful-core.php.svg?style=for-the-badge)](https://travis-ci.org/contentful/contentful-core.php)
+[![Packagist](https://img.shields.io/github/license/contentful/contentful-core.php.svg?style=for-the-badge)](https://packagist.org/packages/contentful/contentful-core.php)
+[![Codecov](https://img.shields.io/codecov/c/github/contentful/contentful-core.php.svg?style=for-the-badge)](https://codecov.io/gh/contentful/contentful-core.php)
 
 ## What is Contentful?
 

src/Api/DateTimeImmutable.php

@@ -14,7 +14,7 @@
  *
  * This class is used for easier conversion to a timestamp that works with Contentful.
  */
-class DateTimeImmutable extends \DateTimeImmutable
+class DateTimeImmutable extends \DateTimeImmutable implements \JsonSerializable
 {
     /**
      * Formats the string for an easier interoperability with Contentful.
@@ -43,4 +43,14 @@ public function __toString()
     {
         return $this->formatForJson();
     }
+
+    /**
+     * Returns a JSON representation of the current object.
+     *
+     * @return string
+     */
+    public function jsonSerialize()
+    {
+        return $this->formatForJson();
+    }
 }

tests/Unit/Api/DateTimeImmutableTest.php

@@ -25,5 +25,6 @@ public function testStringRepresentation()
 
         $this->assertSame('1988-09-19T00:00:00Z', $date->formatForJson());
         $this->assertSame('1988-09-19T00:00:00Z', (string) $date);
+        $this->assertSame('"1988-09-19T00:00:00Z"', \json_encode($date));
     }
 }