Skip to content

Commit b66a7ee

Browse files
feat: rename agent layout variant methods and export LayoutVariant type [EXT-7094] (#2427)
feat: rename agent layout variant methods and export LayoutVariant type - Rename setLayoutVariant to setAgentLayoutVariant - Rename layoutVariantChanged to agentLayoutVariantChanged - Rename onLayoutVariantChange to onAgentLayoutVariantChange - Export LayoutVariant type from types/index.ts - Add validation to setAgentLayoutVariant method - Update channel calls to use new names - Update all tests to use new method names - Add comprehensive validation error tests EXT-6962, EXT-7094
1 parent f33954a commit b66a7ee

File tree

6 files changed

+122
-93
lines changed

6 files changed

+122
-93
lines changed

lib/agent.ts

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ export default function createAgent(
1515

1616
const toolbarActionSignal = new Signal<[ToolbarAction]>()
1717

18-
const layoutVariantChanged = new MemoizedSignal<[LayoutVariant]>('normal')
18+
const agentLayoutVariantChanged = new MemoizedSignal<[LayoutVariant]>('normal')
1919

2020
channel.addHandler('contextChanged', (newContext: AgentContext) => {
2121
contextChanged.dispatch(newContext)
@@ -25,16 +25,19 @@ export default function createAgent(
2525
toolbarActionSignal.dispatch(action)
2626
})
2727

28-
channel.addHandler('layoutVariantChanged', (variant: LayoutVariant) => {
29-
layoutVariantChanged.dispatch(variant)
28+
channel.addHandler('agentLayoutVariantChanged', (variant: LayoutVariant) => {
29+
agentLayoutVariantChanged.dispatch(variant)
3030
})
3131

3232
return {
3333
onContextChange: (handler) => contextChanged.attach(handler),
3434
onToolbarAction: (handler) => toolbarActionSignal.attach(handler),
35-
onLayoutVariantChange: (handler) => layoutVariantChanged.attach(handler),
36-
setLayoutVariant: (variant: LayoutVariant) => {
37-
channel.send('setLayoutVariant', variant)
35+
onAgentLayoutVariantChange: (handler) => agentLayoutVariantChanged.attach(handler),
36+
setAgentLayoutVariant: (variant: LayoutVariant) => {
37+
if (variant !== 'expanded' && variant !== 'normal') {
38+
throw new Error(`Invalid layout variant "${variant}". Expected "expanded" or "normal".`)
39+
}
40+
channel.send('setAgentLayoutVariant', variant)
3841
},
3942
}
4043
}

lib/types/agent.types.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,6 @@ export interface ToolbarAction {
1919
export interface AgentAPI {
2020
onContextChange: (handler: (context: AgentContext) => void) => VoidFunction
2121
onToolbarAction: (handler: (action: ToolbarAction) => void) => VoidFunction
22-
onLayoutVariantChange: (handler: (variant: LayoutVariant) => void) => VoidFunction
23-
setLayoutVariant: (variant: LayoutVariant) => void
22+
onAgentLayoutVariantChange: (handler: (variant: LayoutVariant) => void) => VoidFunction
23+
setAgentLayoutVariant: (variant: LayoutVariant) => void
2424
}

lib/types/index.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,13 @@ export type {
3737
AgentAppSDK,
3838
} from './api.types'
3939

40-
export type { AgentAPI, AgentContext, ToolbarAction, ToolbarActionName } from './agent.types'
40+
export type {
41+
AgentAPI,
42+
AgentContext,
43+
LayoutVariant,
44+
ToolbarAction,
45+
ToolbarActionName,
46+
} from './agent.types'
4147

4248
export type {
4349
AppConfigAPI,

0 commit comments

Comments
 (0)