Skip to content

Sentry as direct dependency causing version conflict #41

@ilovepku

Description

@ilovepku

Hi, when trying to upgrade @sentry/react-native to a newer version, we got the below complaint from npx expo-doctor

✖ Check that no duplicate dependencies are installed
Your project contains duplicate native module dependencies, which should be de-duplicated.
Native builds may only contain one version of any given native module, and having multiple versions of a single Native module installed may lead to unexpected build errors.
Found duplicates for @sentry/react-native:
├─ @sentry/[email protected] (at: ../../node_modules/@sentry/react-native)
└─ @sentry/[email protected] (at: ../../node_modules/@contentpass/react-native-contentpass/node_modules/@sentry/react-native)

Feels like it's from @contentpass/react-native-contentpass relying on a specific version of @sentry/react-native as a direct dependency.

"dependencies": {
"@sentry/react-native": "^6.3.0",
}

Would it be possible to make @sentry/react-native a peer dependency or have us pass the Sentry instance so that we can freely choose our sentry version?

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions