Skip to content

Commit bea67e7

Browse files
author
Kaushik Shetty
committed
fix: rename method to preventFrameClose
1 parent 19d9565 commit bea67e7

File tree

6 files changed

+15
-15
lines changed

6 files changed

+15
-15
lines changed

__test__/fieldModifierLocation/frame.test.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -187,19 +187,19 @@ describe("FieldModifierLocationFrame", () => {
187187
});
188188

189189
describe("preventFrameClose", () => {
190-
it("should not allow user from clicking background", async () => {
191-
await frameInstance.setAllowAppClose(false);
190+
it("should not allow user to close frame by clicking background", async () => {
191+
await frameInstance.preventFrameClose(true);
192192
expect(sendToParent).toHaveBeenCalledTimes(1);
193-
expect(sendToParent).toHaveBeenLastCalledWith("setAllowAppClose", {
194-
isAllowed: false,
193+
expect(sendToParent).toHaveBeenLastCalledWith("preventFrameClose", {
194+
state: true,
195195
});
196196
});
197197

198-
it("should allow user from clicking background", async () => {
199-
await frameInstance.setAllowAppClose(true);
198+
it("should allow user to close frame by clicking background", async () => {
199+
await frameInstance.preventFrameClose(false);
200200
expect(sendToParent).toHaveBeenCalledTimes(1);
201-
expect(sendToParent).toHaveBeenLastCalledWith("setAllowAppClose", {
202-
isAllowed: true,
201+
expect(sendToParent).toHaveBeenLastCalledWith("preventFrameClose", {
202+
state: false,
203203
});
204204
});
205205
});

dist/index.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/index.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/src/fieldModifierLocation/frame.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ declare class FieldModifierLocationFrame {
2727
* Prevent user from accidently closing the app by clicking outside the frame
2828
* if the app is performing some active task.
2929
*/
30-
setAllowAppClose(isAllowed: boolean): Promise<void>;
30+
preventFrameClose(state: boolean): Promise<void>;
3131
/**
3232
* This method enables auto resizing of the extension height.
3333
* @return {FieldModifierLocationFrame}.

dist/src/fieldModifierLocation/frame.d.ts.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/fieldModifierLocation/frame.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -93,9 +93,9 @@ class FieldModifierLocationFrame {
9393
* Prevent user from accidently closing the app by clicking outside the frame
9494
* if the app is performing some active task.
9595
*/
96-
async setAllowAppClose(isAllowed: boolean) {
97-
await this._connection.sendToParent("setAllowAppClose", {
98-
isAllowed,
96+
async preventFrameClose(state: boolean) {
97+
await this._connection.sendToParent("preventFrameClose", {
98+
state,
9999
});
100100
}
101101

0 commit comments

Comments
 (0)