Skip to content

Commit 1e5eca7

Browse files
authored
Merge pull request #63 from contentstack/development
DX-1492
2 parents 3cc882e + f065229 commit 1e5eca7

File tree

5 files changed

+14
-5
lines changed

5 files changed

+14
-5
lines changed

.github/workflows/npm-publish.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
- uses: actions/checkout@v3
1414
- uses: actions/setup-node@v3
1515
with:
16-
node-version: '18.x'
16+
node-version: '20.x'
1717
registry-url: 'https://registry.npmjs.org'
1818
- run: npm ci
1919
- run: npm publish --access public
@@ -25,7 +25,7 @@ jobs:
2525
- uses: actions/checkout@v3
2626
- uses: actions/setup-node@v3
2727
with:
28-
node-version: '18.x'
28+
node-version: '20.x'
2929
registry-url: 'https://npm.pkg.github.com'
3030
scope: '@contentstack'
3131
- run: npm ci

CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,12 @@
11
## Change log
2+
### Version: 1.1.3
3+
#### Date: Oct-22-2024
4+
- Fix: getData to receive params and headers both in data
5+
6+
## Change log
7+
### Version: 1.1.2
8+
#### Date: Oct-22-2024
9+
- Node version bump
210

311
### Version: 1.1.1
412
#### Date: Aug-28-2024

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@contentstack/core",
3-
"version": "1.1.2",
3+
"version": "1.1.3",
44
"type": "commonjs",
55
"main": "./dist/cjs/src/index.js",
66
"types": "./dist/cjs/src/index.d.ts",

src/lib/request.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ export async function getData(instance: AxiosInstance, url: string, data?: any)
2323
}
2424
}
2525
}
26-
const response = await instance.get(url, { params: data });
26+
const response = await instance.get(url, data);
2727

2828
if (response && response.data) {
2929
return response.data;

src/lib/retryPolicy/delivery-sdk-handlers.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,10 @@ export const retryResponseErrorHandler = (error: any, config: any, axiosInstance
5050
if (error.response && error.response.data) {
5151
return Promise.reject(error.response.data);
5252
}
53+
5354
return Promise.reject(error);
5455
}
55-
error.config.retryCount = retryCount;
56+
error.config.retryCount = retryCount;
5657

5758
return axiosInstance(error.config);
5859
}

0 commit comments

Comments
 (0)