Skip to content

Commit 7d3b120

Browse files
Vikram KaltaVikram Kalta
authored andcommitted
fix: added test cases for only and except filters
1 parent f22fd23 commit 7d3b120

File tree

4 files changed

+25
-5
lines changed

4 files changed

+25
-5
lines changed

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/lib/base-query.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -209,15 +209,14 @@ export class BaseQuery extends Pagination {
209209
requestParams = { ...this._queryParams, query: { ...this._parameters } };
210210
}
211211

212-
const getRequestOptions: any = { params: requestParams };
212+
const getRequestOptions: any = requestParams;
213213

214214
if (this._variants) {
215215
getRequestOptions.headers = {
216216
...getRequestOptions.headers,
217217
'x-cs-variant-uid': this._variants
218218
};
219219
}
220-
221220
const response = await getData(this._client, this._urlPath, getRequestOptions);
222221

223222
return response as FindResponse<T>;

src/lib/entry-queryable.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ export class EntryQueryable extends BaseQuery {
2525
} else {
2626
this._queryParams["only[BASE][]"] = fieldUid;
2727
}
28-
2928
return this;
3029
}
3130

test/api/entry-queryables.spec.ts

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -258,6 +258,28 @@ describe('Query Operators API test cases', () => {
258258

259259
}
260260
});
261+
262+
it('should check for projected fields after only filter is applied', async () => {
263+
const query = makeEntries('contenttype_uid2').only(['title', 'reference'])
264+
const result = await query.find<TEntry>();
265+
if (result.entries) {
266+
expect(result.entries.length).toBeGreaterThan(0);
267+
expect(result.entries[0].reference).toBeDefined();
268+
expect(result.entries[0].title).toBeDefined();
269+
expect(result.entries[0]._version).toBeUndefined();
270+
}
271+
});
272+
273+
it('should ignore fields after except filter is applied', async () => {
274+
const query = makeEntries('contenttype_uid2').except(['title', 'reference'])
275+
const result = await query.find<TEntry>();
276+
if (result.entries) {
277+
expect(result.entries.length).toBeGreaterThan(0);
278+
expect(result.entries[0].reference).toBeUndefined();
279+
expect(result.entries[0].title).toBeUndefined();
280+
expect(result.entries[0]._version).toBeDefined();
281+
}
282+
});
261283
});
262284

263285
function makeEntries(contentTypeUid = ''): Entries {

0 commit comments

Comments
 (0)