Skip to content

Conversation

@harshithad0703
Copy link
Contributor

No description provided.

…kdirp to version 3.0.1. Refactor fs utility functions to use the updated mkdirp import style.
@harshithad0703 harshithad0703 requested a review from a team as a code owner June 12, 2025 06:22
@harshithad0703 harshithad0703 requested review from Copilot and removed request for a team June 12, 2025 06:22

This comment was marked as outdated.

@harshithad0703 harshithad0703 requested a review from Copilot June 12, 2025 06:31

This comment was marked as outdated.

@harshithad0703 harshithad0703 requested a review from Copilot June 12, 2025 06:47

This comment was marked as outdated.

@harshithad0703 harshithad0703 requested a review from Copilot June 12, 2025 06:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses the error reading sync by updating the usage of the mkdirp dependency and refining the mkdir function implementation.

  • Updated import of mkdirp to include synchronous and asynchronous methods.
  • Refactored the mkdir function to use a promise chain instead of callbacks.
  • Upgraded the mkdirp dependency version and updated relevant configuration checks.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/util/fs.ts Replaced sync method call and refactored mkdir to use promises.
package.json Bumped package and dependency versions in support of the changes.
.talismanrc Updated checksum for package-lock.json configuration.
Comments suppressed due to low confidence (1)

src/util/fs.ts:103

  • The mkdir function now always resolves with an empty string, which might be non-intuitive for API consumers. Consider returning void or a more meaningful value, or add documentation to clarify the expected behavior.
return mkdirp(path).then(() => '')

@harshithad0703 harshithad0703 marked this pull request as draft June 12, 2025 06:58
@harshithad0703 harshithad0703 marked this pull request as ready for review June 12, 2025 07:21
@harshithad0703 harshithad0703 merged commit 19daaf9 into development Jun 12, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants