Skip to content

Commit 3bb444c

Browse files
committed
merge pass
1 parent 5b8c3f8 commit 3bb444c

File tree

2 files changed

+26
-10
lines changed

2 files changed

+26
-10
lines changed

src/visualBuilder/__test__/hover/fields/group.test.ts

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import { FieldSchemaMap } from "../../../utils/fieldSchemaMap";
88
import { mockDomRect } from "./mockDomRect";
99
import { VisualBuilder } from "../../../index";
1010
import { screen } from "@testing-library/preact";
11+
import { waitFor } from "@testing-library/preact";
1112

1213
vi.mock("../../../utils/visualBuilderPostMessage", async () => {
1314
const { getAllContentTypes } = await vi.importActual<
@@ -121,8 +122,17 @@ describe("When an element is hovered in visual builder mode", () => {
121122
Config.set("mode", 2);
122123
Config.set("enable", true);
123124
visualBuilder = new VisualBuilder();
124-
// Wait for VisualBuilder to initialize
125-
await new Promise((resolve) => setTimeout(resolve, 0));
125+
// Wait for VisualBuilder to initialize and container to appear
126+
// CI environments are slower, so use generous timeout
127+
await waitFor(
128+
() => {
129+
const container = document.querySelector(
130+
'[data-testid="visual-builder__container"]'
131+
);
132+
if (!container) throw new Error("Container not found");
133+
},
134+
{ timeout: 2000, interval: 50 } // Increased timeout and interval for CI
135+
);
126136
});
127137

128138
beforeEach(() => {

src/visualBuilder/utils/__test__/updateFocussedState.test.ts

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,13 @@ import {
44
updateFocussedStateOnMutation,
55
} from "../updateFocussedState";
66
import { VisualBuilder } from "../..";
7-
import {
8-
addFocusOverlay,
9-
hideOverlay,
10-
} from "../../generators/generateOverlay";
7+
import { addFocusOverlay, hideOverlay } from "../../generators/generateOverlay";
118
import { mockGetBoundingClientRect } from "../../../__test__/utils";
129
import { act } from "@testing-library/preact";
1310
import { singleLineFieldSchema } from "../../../__test__/data/fields";
1411
import { fetchEntryPermissionsAndStageDetails } from "../fetchEntryPermissionsAndStageDetails";
1512
import { isFieldDisabled } from "../isFieldDisabled";
13+
import { getEntryPermissionsCached } from "../getEntryPermissionsCached";
1614

1715
vi.mock("../../generators/generateOverlay", () => ({
1816
addFocusOverlay: vi.fn(),
@@ -23,6 +21,10 @@ vi.mock("../fetchEntryPermissionsAndStageDetails", () => ({
2321
fetchEntryPermissionsAndStageDetails: vi.fn(),
2422
}));
2523

24+
vi.mock("../getEntryPermissionsCached", () => ({
25+
getEntryPermissionsCached: vi.fn(),
26+
}));
27+
2628
vi.mock("../../utils/isFieldDisabled", () => ({
2729
isFieldDisabled: vi.fn().mockReturnValue({ isDisabled: false }),
2830
}));
@@ -39,7 +41,6 @@ vi.mock("../../utils/fieldSchemaMap", () => {
3941
};
4042
});
4143

42-
4344
describe("updateFocussedState", () => {
4445
beforeEach(() => {
4546
const previousSelectedEditableDOM = document.createElement("div");
@@ -50,7 +51,7 @@ describe("updateFocussedState", () => {
5051
document.body.appendChild(previousSelectedEditableDOM);
5152
VisualBuilder.VisualBuilderGlobalState.value.previousSelectedEditableDOM =
5253
previousSelectedEditableDOM;
53-
54+
5455
// Set up default mock for fetchEntryPermissionsAndStageDetails for all tests
5556
vi.mocked(fetchEntryPermissionsAndStageDetails).mockResolvedValue({
5657
acl: {
@@ -287,12 +288,17 @@ describe("updateFocussedState", () => {
287288
} as unknown as ResizeObserver;
288289

289290
const previousSelectedEditableDOM = document.createElement("div");
290-
previousSelectedEditableDOM.setAttribute("data-cslp", "content_type_uid.entry_uid.locale.field_path");
291+
previousSelectedEditableDOM.setAttribute(
292+
"data-cslp",
293+
"content_type_uid.entry_uid.locale.field_path"
294+
);
291295
document.body.appendChild(previousSelectedEditableDOM);
292296
VisualBuilder.VisualBuilderGlobalState.value.previousSelectedEditableDOM =
293297
previousSelectedEditableDOM;
294298

295-
document.querySelector = vi.fn().mockReturnValue(previousSelectedEditableDOM);
299+
document.querySelector = vi
300+
.fn()
301+
.mockReturnValue(previousSelectedEditableDOM);
296302

297303
const result = await updateFocussedState({
298304
editableElement: editableElementMock,

0 commit comments

Comments
 (0)