added enableLivePreviewOutsideIframe key to on or off the outside iframe feature by default #525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de iframe feature by default
…de iframe feature by default
prathamesh-sawant-cs
approved these changes
Nov 18, 2025
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
KANE-99
approved these changes
Nov 18, 2025
Contributor
KANE-99
left a comment
KANE-99
left a comment
There was a problem hiding this comment.
The changes look good to me; however, what about the scenario where the user isn’t using the Live Preview SDK and is instead initializing directly via postMessage?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added enableLivePreviewOutsideIframe key to on or off the outside iframe feature by default