refactor:resolved PR comments

Author: AishDani

api/src/services/taxonomy.service.ts

@@ -43,17 +43,17 @@ const getDescendantsTerm = async ( {authtoken,taxonomyUid, termUid, region, stac
             for (const term of terms) {
       // Push current term
       allTerms.push({
-        uid: term.uid,
-        name: term.name,
-        parent_uid: term.parent_uid,
+        uid: term?.uid,
+        name: term?.name,
+        parent_uid: term?.parent_uid,
       });
 
       // Recursively fetch deeper descendants
-      if (term.children_count > 0) {
+      if (term?.children_count > 0) {
         const nestedTerms = await getDescendantsTerm({
           authtoken,
           taxonomyUid,
-          termUid: term.uid,
+          termUid: term?.uid,
           region,
           stackId,
         });
@@ -65,7 +65,7 @@ const getDescendantsTerm = async ( {authtoken,taxonomyUid, termUid, region, stac
     }
         return allTerms; 
     } catch (error) {
-        console.error("🚀 ~ getDescendantsTerm ~ error:", error);
+        logger.error("🚀 ~ getDescendantsTerm ~ error:", error);
         throw error;
 
     }
@@ -92,25 +92,23 @@ const createTerms = async(
         for (const term of termsData || []) {
             if (term?.uid) {
                 allTerms.push({
-                uid: term.uid,
-                name: term.name,
-                parent_uid: term.parent_uid,
+                uid: term?.uid,
+                name: term?.name,
+                parent_uid: term?.parent_uid,
                 });
 
                 if (term?.children_count > 0) {
                 const nestedTerms = await getDescendantsTerm({
                     authtoken,
                     taxonomyUid,
-                    termUid: term.uid,
+                    termUid: term?.uid,
                     region,
                     stackId,
                 });
 
                 if (Array.isArray(nestedTerms)) {
                     allTerms.push(...nestedTerms);
                 }
-
-                console.info("🚀 ~ createTerms ~ nestedTerms:", nestedTerms);
                 }
             }
         }
@@ -131,7 +129,7 @@ const createTerms = async(
     return allTerms;
 
     } catch (error) {
-        console.error("🚀 ~ createTaxonomy ~ error:", error);
+        logger.error("🚀 ~ createTaxonomy ~ error:", error);
         throw error;
 
     }
@@ -173,31 +171,33 @@ const createTaxonomy = async ({stackId,region,userId,current_test_stack_id} :
         }
 
         const taxonomiesDataObject: Record<string, any> = {};
-        res?.data?.taxonomies?.forEach(async (taxonomy: any) => {
-            if (taxonomy?.uid) {
-                taxonomiesDataObject[taxonomy.uid] = {
-                uid: taxonomy?.uid,
-                name: taxonomy?.name,
-                description: taxonomy?.description,
-                };
-                const singleTaxonomy: any= {};
-                singleTaxonomy['taxonomy']= {
-                uid: taxonomy?.uid,
-                name: taxonomy?.name,
-                description: taxonomy?.description,
+        if (res?.data?.taxonomies) {
+            for (const taxonomy of res.data.taxonomies) {
+                if (taxonomy?.uid) {
+                    taxonomiesDataObject[taxonomy.uid] = {
+                        uid: taxonomy?.uid,
+                        name: taxonomy?.name,
+                        description: taxonomy?.description,
+                    };
+                    const singleTaxonomy: any = {};
+                    singleTaxonomy['taxonomy'] = {
+                        uid: taxonomy?.uid,
+                        name: taxonomy?.name,
+                        description: taxonomy?.description,
+                    };
+                    singleTaxonomy['terms'] = await createTerms({ authtoken, taxonomyUid: taxonomy?.uid, region, stackId });
+                    await fs.promises.writeFile(path.join(taxonomiesPath, `${taxonomy?.uid}.json`), JSON.stringify(singleTaxonomy, null, 2));
                 }
-                singleTaxonomy['terms'] = await createTerms({authtoken,taxonomyUid: taxonomy?.uid,region, stackId});
-                await fs.promises.writeFile(path.join(taxonomiesPath, `${taxonomy?.uid}.json`), JSON.stringify(singleTaxonomy, null, 2));
             }
-        });
+        }
 
         const filePath = path.join(taxonomiesPath, TAXONOMIES_FILE_NAME);
         await fs.promises.writeFile(filePath, JSON.stringify(taxonomiesDataObject, null, 2));
 
 
 
     } catch (error) {
-    console.error("🚀 ~ createTaxonomy ~ error:", error);
+    logger.error("🚀 ~ createTaxonomy ~ error:", error);
     throw error;
   }
 

ui/src/components/ContentMapper/index.tsx

@@ -522,7 +522,7 @@ const ContentMapper = forwardRef(({ handleStepChange }: contentMapperProps, ref:
       value?.data_type !== 'group' &&
       value?.label?.includes(item?.display_name)
     ) {
-       setIsUpdated(true)
+      setIsUpdated(true);
       updatedRows = updatedRows?.map((row: FieldMapType) => {
 
         if (row?.uid === key && row?.backupFieldType === value?.value?.data_type) {

ui/src/pages/Migration/index.tsx

@@ -127,7 +127,7 @@ const Migration = () => {
 
   useBlockNavigation(isModalOpen);
 
-  useEffect(()=>{
+  useEffect (()=>{
     const hasNonEmptyMapping =
     newMigrationData?.destination_stack?.localeMapping &&
     Object.entries(newMigrationData?.destination_stack?.localeMapping || {})?.every(
@@ -150,7 +150,7 @@ const Migration = () => {
     else{
       setIsSaved(false);
     }
-  },[isCompleted, newMigrationData])
+  }, [isCompleted, newMigrationData])
 
   /**
    * Function to get exisiting content types list