fix: optimize locale fallback logic by moving masterLocaleData declaration

umeshmore45 · umeshmore45 · commit 932fb2308e6d · 2025-04-07T02:30:11.000+05:30
diff --git a/api/src/services/contentful.service.ts b/api/src/services/contentful.service.ts
@@ -969,8 +969,8 @@ const createLocale = async (packagePath: string, destination_stack_id: string, p
       }
       localeList[title] = newLocale;
     }));
+    const masterLocaleData = Object?.values(msLocale)?.[0];
     for (const [key, value] of Object.entries(allLocales) ?? {}) {
-      const masterLocaleData = Object?.values(msLocale)?.[0];
       if (value?.code === masterLocaleData?.fallback_locale) {
         allLocales[key].fallback_locale = masterLocaleData?.code
       }

Original file line number	Diff line number	Diff line change
`@@ -969,8 +969,8 @@ const createLocale = async (packagePath: string, destination_stack_id: string, p`
`969`	`969`	`}`
`970`	`970`	`localeList[title] = newLocale;`
`971`	`971`	`}));`
	`972`	`+ const masterLocaleData = Object?.values(msLocale)?.[0];`
`972`	`973`	`for (const [key, value] of Object.entries(allLocales) ?? {}) {`
`973`		`- const masterLocaleData = Object?.values(msLocale)?.[0];`
`974`	`974`	`if (value?.code === masterLocaleData?.fallback_locale) {`
`975`	`975`	`allLocales[key].fallback_locale = masterLocaleData?.code`
`976`	`976`	`}`